| Message ID | 20220307090804.4821-1-guozhengkui@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0c1794c200e943ea95a28c0a8c7eda6b5c004a9d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD | expand |
Hi Guo, Thanks for your work. On 2022-03-07 17:07:59 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warning: > drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING > avoid newline at end of message in NL_SET_ERR_MSG_MOD > > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com> > --- > drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > index 00a09b9e0aee..d5ff80a62882 100644 > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c > @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp, > > if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) { > NL_SET_ERR_MSG_MOD(extack, > - "XSK buffer pool chunk size too small\n"); > + "XSK buffer pool chunk size too small"); > return -EINVAL; > } > } > -- > 2.20.1 >
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 7 Mar 2022 17:07:59 +0800 you wrote: > Fix the following coccicheck warning: > drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING > avoid newline at end of message in NL_SET_ERR_MSG_MOD > > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> > --- > drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - nfp: xsk: avoid newline at the end of message in NL_SET_ERR_MSG_MOD https://git.kernel.org/netdev/net-next/c/0c1794c200e9 You are awesome, thank you!
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 00a09b9e0aee..d5ff80a62882 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -3431,7 +3431,7 @@ nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp, if (xsk_pool_get_rx_frame_size(dp->xsk_pools[r]) < xsk_min_fl_bufsz) { NL_SET_ERR_MSG_MOD(extack, - "XSK buffer pool chunk size too small\n"); + "XSK buffer pool chunk size too small"); return -EINVAL; } }
Fix the following coccicheck warning: drivers/net/ethernet/netronome/nfp/nfp_net_common.c:3434:8-48: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)