| Message ID | 20220308100034.29035-1-guozhengkui@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | drivers: vxlan: fix returnvar.cocci warning | expand |
Hello, On Tue, 2022-03-08 at 18:00 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warning: > > drivers/net/vxlan/vxlan_core.c:2995:5-8: > Unneeded variable: "ret". Return "0" on line 3004. > > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> Please specify a target tree (likely net-next) in the patch subj. Additionally, this looks worthy a "Fixes" tag, likely: Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device") Thanks, Paolo
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index b3cbd37c4b93..e06158a42823 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -2986,28 +2986,27 @@ static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all) } spin_unlock_bh(&vxlan->hash_lock[h]); } } /* Cleanup timer and forwarding table on shutdown */ static int vxlan_stop(struct net_device *dev) { struct vxlan_dev *vxlan = netdev_priv(dev); - int ret = 0; vxlan_multicast_leave(vxlan); del_timer_sync(&vxlan->age_timer); vxlan_flush(vxlan, false); vxlan_sock_release(vxlan); - return ret; + return 0; } /* Stub, nothing needs to be done. */ static void vxlan_set_multicast_list(struct net_device *dev) { } static int vxlan_change_mtu(struct net_device *dev, int new_mtu) {
Fix the following coccicheck warning: drivers/net/vxlan/vxlan_core.c:2995:5-8: Unneeded variable: "ret". Return "0" on line 3004. Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> --- drivers/net/vxlan/vxlan_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)