diff mbox series

[iproute2-next,1/2] bridge: support for controlling flooding of broadcast per port

Message ID 20220308132915.2610480-2-troglobit@gmail.com (mailing list archive)
State Superseded
Delegated to: David Ahern
Headers show
Series bridge: support for controlling broadcast flooding per port | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Joachim Wiberg March 8, 2022, 1:29 p.m. UTC 
Add per-port support for controlling flooding of broadcast traffic.
Similar to unicast and multcast flooding that already exist.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
---
 bridge/link.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Nikolay Aleksandrov March 8, 2022, 4:11 p.m. UTC | #1 
On 08/03/2022 15:29, Joachim Wiberg wrote:
> Add per-port support for controlling flooding of broadcast traffic.
> Similar to unicast and multcast flooding that already exist.
> 
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
>  bridge/link.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Nice, thanks for adding this. Please also update ip/iplink_bridge_slave.c and the
respective docs with the bcast flag, it already supports the other two.
Joachim Wiberg March 9, 2022, 6:14 a.m. UTC | #2 
On Tue, Mar 08, 2022 at 18:11, Nikolay Aleksandrov <razor@blackwall.org> wrote:
> On 08/03/2022 15:29, Joachim Wiberg wrote:
>> Add per-port support for controlling flooding of broadcast traffic.
>> Similar to unicast and multcast flooding that already exist.
> Nice, thanks for adding this. Please also update ip/iplink_bridge_slave.c and the
> respective docs with the bcast flag, it already supports the other two.

Aha, there are knobs and levers over there too!  OK, will do :-)

 /J
diff mbox series

Patch

diff --git a/bridge/link.c b/bridge/link.c
index bc7837a9..407dc8ea 100644
--- a/bridge/link.c
+++ b/bridge/link.c
@@ -153,6 +153,9 @@  static void print_protinfo(FILE *fp, struct rtattr *attr)
 		if (prtb[IFLA_BRPORT_MCAST_FLOOD])
 			print_on_off(PRINT_ANY, "mcast_flood", "mcast_flood %s ",
 				     rta_getattr_u8(prtb[IFLA_BRPORT_MCAST_FLOOD]));
+		if (prtb[IFLA_BRPORT_BCAST_FLOOD])
+			print_on_off(PRINT_ANY, "bcast_flood", "bcast_flood %s ",
+				     rta_getattr_u8(prtb[IFLA_BRPORT_BCAST_FLOOD]));
 		if (prtb[IFLA_BRPORT_MCAST_TO_UCAST])
 			print_on_off(PRINT_ANY, "mcast_to_unicast", "mcast_to_unicast %s ",
 				     rta_getattr_u8(prtb[IFLA_BRPORT_MCAST_TO_UCAST]));
@@ -265,6 +268,7 @@  static void usage(void)
 		"                               [ learning_sync {on | off} ]\n"
 		"                               [ flood {on | off} ]\n"
 		"                               [ mcast_flood {on | off} ]\n"
+		"                               [ bcast_flood {on | off} ]\n"
 		"                               [ mcast_to_unicast {on | off} ]\n"
 		"                               [ neigh_suppress {on | off} ]\n"
 		"                               [ vlan_tunnel {on | off} ]\n"
@@ -296,6 +300,7 @@  static int brlink_modify(int argc, char **argv)
 	__s8 flood = -1;
 	__s8 vlan_tunnel = -1;
 	__s8 mcast_flood = -1;
+	__s8 bcast_flood = -1;
 	__s8 mcast_to_unicast = -1;
 	__s8 isolated = -1;
 	__s8 hairpin = -1;
@@ -354,6 +359,11 @@  static int brlink_modify(int argc, char **argv)
 			mcast_flood = parse_on_off("mcast_flood", *argv, &ret);
 			if (ret)
 				return ret;
+		} else if (strcmp(*argv, "bcast_flood") == 0) {
+			NEXT_ARG();
+			bcast_flood = parse_on_off("bcast_flood", *argv, &ret);
+			if (ret)
+				return ret;
 		} else if (strcmp(*argv, "mcast_to_unicast") == 0) {
 			NEXT_ARG();
 			mcast_to_unicast = parse_on_off("mcast_to_unicast", *argv, &ret);
@@ -456,6 +466,9 @@  static int brlink_modify(int argc, char **argv)
 	if (mcast_flood >= 0)
 		addattr8(&req.n, sizeof(req), IFLA_BRPORT_MCAST_FLOOD,
 			 mcast_flood);
+	if (bcast_flood >= 0)
+		addattr8(&req.n, sizeof(req), IFLA_BRPORT_BCAST_FLOOD,
+			 bcast_flood);
 	if (mcast_to_unicast >= 0)
 		addattr8(&req.n, sizeof(req), IFLA_BRPORT_MCAST_TO_UCAST,
 			 mcast_to_unicast);