diff mbox series

[net-next,v2] net: dsa: tag_rtl8_4: fix typo in modalias name

Message ID 20220309022757.9539-1-luizluca@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v2] net: dsa: tag_rtl8_4: fix typo in modalias name | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes fail Problems with Fixes tag: 1
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch warning WARNING: Unknown commit id '7c33ef0ad83d', maybe rebased or not pulled?
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Luiz Angelo Daros de Luca March 9, 2022, 2:27 a.m. UTC
DSA_TAG_PROTO_RTL8_4L is not defined. It should be
DSA_TAG_PROTO_RTL8_4T.

Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
 net/dsa/tag_rtl8_4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli March 9, 2022, 3:19 a.m. UTC | #1
On 3/8/2022 6:27 PM, Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
> 
> Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
> Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Jakub Kicinski March 9, 2022, 6:03 a.m. UTC | #2
On Tue,  8 Mar 2022 23:27:58 -0300 Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
> 
> Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")

This SHA does not exist upstream.
Luiz Angelo Daros de Luca March 9, 2022, 5:31 p.m. UTC | #3
> > Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
>
> This SHA does not exist upstream.

Sorry, I got it from a backport branch. I'll send v3. Thanks for the review.

Regards,

Luiz
diff mbox series

Patch

diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
index 71fec45fd0ea..a593ead7ff26 100644
--- a/net/dsa/tag_rtl8_4.c
+++ b/net/dsa/tag_rtl8_4.c
@@ -247,7 +247,7 @@  static const struct dsa_device_ops rtl8_4t_netdev_ops = {
 
 DSA_TAG_DRIVER(rtl8_4t_netdev_ops);
 
-MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4L);
+MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4T);
 
 static struct dsa_tag_driver *dsa_tag_drivers[] = {
 	&DSA_TAG_DRIVER_NAME(rtl8_4_netdev_ops),