diff mbox series

atm: eni: Add check for dma_map_single

Message ID 20220311071656.2062663-1-jiasheng@iscas.ac.cn (mailing list archive)
State Superseded
Headers show
Series atm: eni: Add check for dma_map_single | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 2 this patch: 2
netdev/cc_maintainers success CCed 3 of 3 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 2 this patch: 2
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Jiasheng Jiang March 11, 2022, 7:16 a.m. UTC 
As the potential failure of the dma_map_single(),
it should be better to check it and return error
if fails.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/atm/eni.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jakub Kicinski March 12, 2022, 7:04 a.m. UTC | #1 
On Fri, 11 Mar 2022 15:16:56 +0800 Jiasheng Jiang wrote:
> As the potential failure of the dma_map_single(),
> it should be better to check it and return error
> if fails.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/atm/eni.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
> index 422753d52244..96c2d8f5646b 100644
> --- a/drivers/atm/eni.c
> +++ b/drivers/atm/eni.c
> @@ -1112,6 +1112,8 @@ DPRINTK("iovcnt = %d\n",skb_shinfo(skb)->nr_frags);
>  	skb_data3 = skb->data[3];
>  	paddr = dma_map_single(&eni_dev->pci_dev->dev,skb->data,skb->len,
>  			       DMA_TO_DEVICE);
> +	if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr))
> +		return enq_jam;

Probably better to drop the packet if mapping fails.

>  	ENI_PRV_PADDR(skb) = paddr;
>  	/* prepare DMA queue entries */
>  	j = 0;
diff mbox series

Patch

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 422753d52244..96c2d8f5646b 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1112,6 +1112,8 @@  DPRINTK("iovcnt = %d\n",skb_shinfo(skb)->nr_frags);
 	skb_data3 = skb->data[3];
 	paddr = dma_map_single(&eni_dev->pci_dev->dev,skb->data,skb->len,
 			       DMA_TO_DEVICE);
+	if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr))
+		return enq_jam;
 	ENI_PRV_PADDR(skb) = paddr;
 	/* prepare DMA queue entries */
 	j = 0;