| Message ID | 20220311125437.3854483-3-ioana.ciornei@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dpaa2-mac: add support for changing the protocol at runtime | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 47 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 11/03/2022 13:54, Ioana Ciornei wrote: > Describe the "fsl,lynx-28g" compatible used by the Lynx 28G SerDes PHY > driver on Layerscape based SoCs. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> > --- > Changes in v2: > - none > Changes in v3: > - 2/8: fix 'make dt_binding_check' errors > Changes in v4: > - 2/8: remove the lane DT nodes > > .../devicetree/bindings/phy/fsl,lynx-28g.yaml | 40 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml > > diff --git a/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml > new file mode 100644 > index 000000000000..dd1adf7b3c05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/fsl,lynx-28g.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale Lynx 28G SerDes PHY binding > + > +maintainers: > + - Ioana Ciornei <ioana.ciornei@nxp.com> > + > +properties: > + compatible: > + enum: > + - fsl,lynx-28g > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + serdes_1: serdes_phy@1ea0000 { Comment from v3 still unresolved. Rest looks good. Best regards, Krzysztof
On Fri, Mar 11, 2022 at 02:09:05PM +0100, Krzysztof Kozlowski wrote: > On 11/03/2022 13:54, Ioana Ciornei wrote: > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + serdes_1: serdes_phy@1ea0000 { > > Comment from v3 still unresolved. Rest looks good. Uhhh, I forgot to change the name. Sorry. Do you have in plan to look at any other patch? I am asking just so I know when to send a v4. Thanks, Ioana
On 11/03/2022 14:13, Ioana Ciornei wrote: > On Fri, Mar 11, 2022 at 02:09:05PM +0100, Krzysztof Kozlowski wrote: >> On 11/03/2022 13:54, Ioana Ciornei wrote: >>> +examples: >>> + - | >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + serdes_1: serdes_phy@1ea0000 { >> >> Comment from v3 still unresolved. Rest looks good. > > Uhhh, I forgot to change the name. Sorry. > > Do you have in plan to look at any other patch? I am asking just so I > know when to send a v4. > No, I am just checking the bindings. Maybe wait a bit before sending v4 to give other people chance to review :) Best regards, Krzysztof
On 11/03/2022 14:13, Ioana Ciornei wrote: > On Fri, Mar 11, 2022 at 02:09:05PM +0100, Krzysztof Kozlowski wrote: >> On 11/03/2022 13:54, Ioana Ciornei wrote: >>> +examples: >>> + - | >>> + soc { >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + serdes_1: serdes_phy@1ea0000 { >> >> Comment from v3 still unresolved. Rest looks good. > > Uhhh, I forgot to change the name. Sorry. With the node name "phy": Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml new file mode 100644 index 000000000000..dd1adf7b3c05 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/fsl,lynx-28g.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale Lynx 28G SerDes PHY binding + +maintainers: + - Ioana Ciornei <ioana.ciornei@nxp.com> + +properties: + compatible: + enum: + - fsl,lynx-28g + + reg: + maxItems: 1 + + "#phy-cells": + const: 1 + +required: + - compatible + - reg + - "#phy-cells" + +additionalProperties: false + +examples: + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + serdes_1: serdes_phy@1ea0000 { + compatible = "fsl,lynx-28g"; + reg = <0x0 0x1ea0000 0x0 0x1e30>; + #phy-cells = <1>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 3e76c8cd8a3a..3aa185235a52 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11340,6 +11340,7 @@ LYNX 28G SERDES PHY DRIVER M: Ioana Ciornei <ioana.ciornei@nxp.com> L: netdev@vger.kernel.org S: Supported +F: Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml F: drivers/phy/freescale/phy-fsl-lynx-28g.c LYNX PCS MODULE
Describe the "fsl,lynx-28g" compatible used by the Lynx 28G SerDes PHY driver on Layerscape based SoCs. Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- Changes in v2: - none Changes in v3: - 2/8: fix 'make dt_binding_check' errors Changes in v4: - 2/8: remove the lane DT nodes .../devicetree/bindings/phy/fsl,lynx-28g.yaml | 40 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl,lynx-28g.yaml