diff mbox series

selftests/bpf: fix tunnel remote ip comments

Message ID 20220313164116.5889-1-fankaixi.li@bytedance.com (mailing list archive)
State Accepted
Commit a50cbac6d81a7a3965d82a9af8b62dc055917c2b
Delegated to: BPF
Headers show
Series selftests/bpf: fix tunnel remote ip comments | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
bpf/vmtest-bpf-next success VM_Test
netdev/tree_selection success Not a local patch

Commit Message

Kaixi Fan March 13, 2022, 4:41 p.m. UTC
From: "kaixi.fan" <fankaixi.li@bytedance.com>

In namespace at_ns0, the ip address of tnl dev is 10.1.1.100 which
is the overlay ip, and the ip address of veth0 is 172.16.1.100
which is the vtep ip.
When doing 'ping 10.1.1.100' from root namespace, the
remote_ip should be 172.16.1.100.

Fixs: 933a741e ("selftests/bpf: bpf tunnel test.")
Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
---
 tools/testing/selftests/bpf/test_tunnel.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Fastabend March 17, 2022, 3:57 a.m. UTC | #1
fankaixi.li@ wrote:
> From: "kaixi.fan" <fankaixi.li@bytedance.com>
> 
> In namespace at_ns0, the ip address of tnl dev is 10.1.1.100 which
> is the overlay ip, and the ip address of veth0 is 172.16.1.100
> which is the vtep ip.
> When doing 'ping 10.1.1.100' from root namespace, the
> remote_ip should be 172.16.1.100.
> 
> Fixs: 933a741e ("selftests/bpf: bpf tunnel test.")
> Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
> ---
>  tools/testing/selftests/bpf/test_tunnel.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_tunnel.sh b/tools/testing/selftests/bpf/test_tunnel.sh
> index ca1372924023..2817d9948d59 100755
> --- a/tools/testing/selftests/bpf/test_tunnel.sh
> +++ b/tools/testing/selftests/bpf/test_tunnel.sh
> @@ -39,7 +39,7 @@
>  # from root namespace, the following operations happen:
>  # 1) Route lookup shows 10.1.1.100/24 belongs to tnl dev, fwd to tnl dev.
>  # 2) Tnl device's egress BPF program is triggered and set the tunnel metadata,
> -#    with remote_ip=172.16.1.200 and others.
> +#    with remote_ip=172.16.1.100 and others.
>  # 3) Outer tunnel header is prepended and route the packet to veth1's egress
>  # 4) veth0's ingress queue receive the tunneled packet at namespace at_ns0
>  # 5) Tunnel protocol handler, ex: vxlan_rcv, decap the packet
> -- 
> 2.24.3 (Apple Git-128)
> 

checks out.

Acked-by: John Fastabend <john.fastabend@gmail.com>
patchwork-bot+netdevbpf@kernel.org March 17, 2022, 7:50 p.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Mon, 14 Mar 2022 00:41:16 +0800 you wrote:
> From: "kaixi.fan" <fankaixi.li@bytedance.com>
> 
> In namespace at_ns0, the ip address of tnl dev is 10.1.1.100 which
> is the overlay ip, and the ip address of veth0 is 172.16.1.100
> which is the vtep ip.
> When doing 'ping 10.1.1.100' from root namespace, the
> remote_ip should be 172.16.1.100.
> 
> [...]

Here is the summary with links:
  - selftests/bpf: fix tunnel remote ip comments
    https://git.kernel.org/bpf/bpf-next/c/a50cbac6d81a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/test_tunnel.sh b/tools/testing/selftests/bpf/test_tunnel.sh
index ca1372924023..2817d9948d59 100755
--- a/tools/testing/selftests/bpf/test_tunnel.sh
+++ b/tools/testing/selftests/bpf/test_tunnel.sh
@@ -39,7 +39,7 @@ 
 # from root namespace, the following operations happen:
 # 1) Route lookup shows 10.1.1.100/24 belongs to tnl dev, fwd to tnl dev.
 # 2) Tnl device's egress BPF program is triggered and set the tunnel metadata,
-#    with remote_ip=172.16.1.200 and others.
+#    with remote_ip=172.16.1.100 and others.
 # 3) Outer tunnel header is prepended and route the packet to veth1's egress
 # 4) veth0's ingress queue receive the tunneled packet at namespace at_ns0
 # 5) Tunnel protocol handler, ex: vxlan_rcv, decap the packet