| Message ID | 20220314140327.GB30883@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c24f657791fd2df9d7a5491ac43b63658ea7187d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sparx5: fix a couple warning messages | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Mon, 14 Mar 2022 17:03:27 +0300 you wrote: > The WARN_ON() macro takes a condition, not a warning message. > > Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] net: sparx5: fix a couple warning messages https://git.kernel.org/netdev/net-next/c/c24f657791fd You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c index cd110c31e5a4..0ed1ea7727c5 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c @@ -45,7 +45,7 @@ static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5) res = 920535763834; break; default: - WARN_ON("Invalid core clock"); + WARN(1, "Invalid core clock"); break; } @@ -67,7 +67,7 @@ static u64 sparx5_ptp_get_nominal_value(struct sparx5 *sparx5) res = 0x0CC6666666666666; break; default: - WARN_ON("Invalid core clock"); + WARN(1, "Invalid core clock"); break; }
The WARN_ON() macro takes a condition, not a warning message. Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)