| Message ID | 20220316213114.2352352-1-morbo@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c011072c90353814a9d8e2b3cd111e77ae8601ed |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/fsl: xgmac_mdio: use correct format characters | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 16 Mar 2022 14:31:14 -0700 you wrote: > When compiling with -Wformat, clang emits the following warning: > > drivers/net/ethernet/freescale/xgmac_mdio.c:243:22: warning: format > specifies type 'unsigned char' but the argument has type 'int' > [-Wformat] > phy_id, dev_addr, regnum); > ^~~~~~ > ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' > dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > ./include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' > _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > > [...] Here is the summary with links: - net/fsl: xgmac_mdio: use correct format characters https://git.kernel.org/netdev/net-next/c/c011072c9035 You are awesome, thank you!
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index 266e562bd67a..1d5d09d2eb41 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -239,7 +239,7 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum) if ((xgmac_read32(®s->mdio_stat, endian) & MDIO_STAT_RD_ER) && !priv->has_a011043) { dev_dbg(&bus->dev, - "Error while reading PHY%d reg at %d.%hhu\n", + "Error while reading PHY%d reg at %d.%d\n", phy_id, dev_addr, regnum); ret = 0xffff; } else {
When compiling with -Wformat, clang emits the following warning: drivers/net/ethernet/freescale/xgmac_mdio.c:243:22: warning: format specifies type 'unsigned char' but the argument has type 'int' [-Wformat] phy_id, dev_addr, regnum); ^~~~~~ ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ ./include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ The types of these arguments are unconditionally defined, so this patch updates the format character to the correct ones for ints and unsigned ints. Link: ClangBuiltLinux/linux#378 Signed-off-by: Bill Wendling <morbo@google.com> --- drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)