| Message ID | 20220316213125.2353370-1-morbo@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8624a95ecdea5ce6829bb42b0b9dcd8705961e04 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | vlan: use correct format characters | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 16 Mar 2022 14:31:25 -0700 you wrote: > When compiling with -Wformat, clang emits the following warning: > > net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned > short' but the argument has type 'int' [-Wformat] > mp->priority, ((mp->vlan_qos >> 13) & 0x7)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [...] Here is the summary with links: - vlan: use correct format characters https://git.kernel.org/netdev/net-next/c/8624a95ecdea You are awesome, thank you!
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c index 08bf6c839e25..7825c129742a 100644 --- a/net/8021q/vlanproc.c +++ b/net/8021q/vlanproc.c @@ -280,7 +280,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset) const struct vlan_priority_tci_mapping *mp = vlan->egress_priority_map[i]; while (mp) { - seq_printf(seq, "%u:%hu ", + seq_printf(seq, "%u:%d ", mp->priority, ((mp->vlan_qos >> 13) & 0x7)); mp = mp->next; }
When compiling with -Wformat, clang emits the following warning: net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat] mp->priority, ((mp->vlan_qos >> 13) & 0x7)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ The types of these arguments are unconditionally defined, so this patch updates the format character to the correct ones for ints and unsigned ints. Link: ClangBuiltLinux/linux#378 Signed-off-by: Bill Wendling <morbo@google.com> --- net/8021q/vlanproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)