| Message ID | 20220321024149.157861-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ec80906b0fbd7be11e3e960813b977b1ffe5f8fe |
| Delegated to: | BPF |
| Headers | show |
| Series | [PATCHv2,bpf] selftests/bpf/test_lirc_mode2.sh: exit with proper code | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Mon, 21 Mar 2022 10:41:49 +0800 you wrote: > When test_lirc_mode2_user exec failed, the test report failed but still > exit with 0. Fix it by exiting with an error code. > > Another issue is for the LIRCDEV checking. With bash -n, we need to quote > the variable, or it will always be true. So if test_lirc_mode2_user was > not run, just exit with skip code. > > [...] Here is the summary with links: - [PATCHv2,bpf] selftests/bpf/test_lirc_mode2.sh: exit with proper code https://git.kernel.org/bpf/bpf-next/c/ec80906b0fbd You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh index ec4e15948e40..5252b91f48a1 100755 --- a/tools/testing/selftests/bpf/test_lirc_mode2.sh +++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh @@ -3,6 +3,7 @@ # Kselftest framework requirement - SKIP code is 4. ksft_skip=4 +ret=$ksft_skip msg="skip all tests:" if [ $UID != 0 ]; then @@ -25,7 +26,7 @@ do fi done -if [ -n $LIRCDEV ]; +if [ -n "$LIRCDEV" ]; then TYPE=lirc_mode2 ./test_lirc_mode2_user $LIRCDEV $INPUTDEV @@ -36,3 +37,5 @@ then echo -e ${GREEN}"PASS: $TYPE"${NC} fi fi + +exit $ret
When test_lirc_mode2_user exec failed, the test report failed but still exit with 0. Fix it by exiting with an error code. Another issue is for the LIRCDEV checking. With bash -n, we need to quote the variable, or it will always be true. So if test_lirc_mode2_user was not run, just exit with skip code. Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- tools/testing/selftests/bpf/test_lirc_mode2.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)