From patchwork Mon Mar 21 15:53:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun Ramadoss X-Patchwork-Id: 12787444 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A6EC433F5 for ; Mon, 21 Mar 2022 15:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348690AbiCUPzi (ORCPT ); Mon, 21 Mar 2022 11:55:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348660AbiCUPzh (ORCPT ); Mon, 21 Mar 2022 11:55:37 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE00565435; Mon, 21 Mar 2022 08:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1647878051; x=1679414051; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qYChFPbDAfyBQGSHc8vlsYhPBC61xJmrzqLud48m8FQ=; b=MAN3gXI/5WHsRPi35ZTlgfjzosPoBIsFc5h41Nj9d1PIB16ltvQBQmU6 NZCWDSlYscBG9CAIeGDiM4x6Ko3uJfWQL3NnNGdwxLMG8oHbdUPFHDQPZ 6EjtrIpsyNoKmkRxmgbMYMMaIKr7g/jxJAbrIcsiUD+Cm+EJUwZEwsuk5 si/VNu0o3MzIJqUV1Fyu0UExPooaKTJJ4r7v+LvrsK/J1nUc6x7JvuTTn bIOgwNKoAD26DzzR/LHAQhFJRcfPwT2phwr8ZznfjRp8smPpxRsvlbKJy 7ZSV9p8v3Kzw7u9Ib2oA51GyfqxF/L9l2cuglAbFmaCmjhWPBb2zsPDBb Q==; X-IronPort-AV: E=Sophos;i="5.90,199,1643698800"; d="scan'208";a="89617544" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 21 Mar 2022 08:54:10 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 21 Mar 2022 08:54:10 -0700 Received: from CHE-LT-I17769U.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 21 Mar 2022 08:54:04 -0700 From: Arun Ramadoss To: , CC: Paolo Abeni , Jakub Kicinski , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Subject: [RFC Patch net-next 1/3] net: phy: lan87xx: added lan87xx_update_link routine Date: Mon, 21 Mar 2022 21:23:35 +0530 Message-ID: <20220321155337.16260-2-arun.ramadoss@microchip.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220321155337.16260-1-arun.ramadoss@microchip.com> References: <20220321155337.16260-1-arun.ramadoss@microchip.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC The LAN87xx phydev->link has been updated via lan87xx_read_status routine. To get only the recent phydev->link status instead of various other status, refactored the code to have separate lan87xx_update_link routine. Signed-off-by: Arun Ramadoss --- drivers/net/phy/microchip_t1.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c index 389df3f4293c..bb4514254adc 100644 --- a/drivers/net/phy/microchip_t1.c +++ b/drivers/net/phy/microchip_t1.c @@ -674,7 +674,7 @@ static int lan87xx_cable_test_get_status(struct phy_device *phydev, return 0; } -static int lan87xx_read_status(struct phy_device *phydev) +static int lan87xx_update_link(struct phy_device *phydev) { int rc = 0; @@ -687,6 +687,17 @@ static int lan87xx_read_status(struct phy_device *phydev) else phydev->link = 0; + return rc; +} + +static int lan87xx_read_status(struct phy_device *phydev) +{ + int rc = 0; + + rc = lan87xx_update_link(phydev); + if (rc < 0) + return rc; + phydev->speed = SPEED_UNKNOWN; phydev->duplex = DUPLEX_UNKNOWN; phydev->pause = 0;