| Message ID | 20220323080706.212531-1-gongruiqi1@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: mpls: fix memdup.cocci warning | expand |
On Wed, 23 Mar 2022 16:07:06 +0800 GONG, Ruiqi wrote: > Simply use kmemdup instead of explicitly allocating and copying memory. > > Generated by: scripts/coccinelle/api/memdup.cocci > > Fixes: 7d4741eacdef ("net: mpls: Fix notifications when deleting a device") Fixes tag are for bugs. > Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com> net-next is closed during the merge window please repost in 2 weeks.
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index d6fdc5782d33..35b5f806fdda 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -1527,10 +1527,9 @@ static int mpls_ifdown(struct net_device *dev, int event) rt->rt_nh_size; struct mpls_route *orig = rt; - rt = kmalloc(size, GFP_KERNEL); + rt = kmemdup(orig, size, GFP_KERNEL); if (!rt) return -ENOMEM; - memcpy(rt, orig, size); } }
Simply use kmemdup instead of explicitly allocating and copying memory. Generated by: scripts/coccinelle/api/memdup.cocci Fixes: 7d4741eacdef ("net: mpls: Fix notifications when deleting a device") Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com> --- net/mpls/af_mpls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)