| Message ID | 20220330012025.29560-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f9512d654f62604664251dedd437a22fe484974a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: sparx5: uses, depends on BRIDGE or !BRIDGE | expand |
On Tue, 29 Mar 2022 18:20:25 -0700 Randy Dunlap wrote: > Fix build errors when BRIDGE=m and SPARX5_SWITCH=y: > > riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305': > sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled' > riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283': > sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled' > > Fixes: 3cfa11bac9bb ("net: sparx5: add the basic sparx5 driver") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Horatiu Vultur <horatiu.vultur@microchip.com> > Cc: Lars Povlsen <lars.povlsen@microchip.com> > Cc: Steen Hegelund <Steen.Hegelund@microchip.com> > Cc: UNGLinuxDriver@microchip.com > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> Gotta CC all the authors of the change under Fixes, please. Adding them now. > --- linux-next-20220329.orig/drivers/net/ethernet/microchip/sparx5/Kconfig > +++ linux-next-20220329/drivers/net/ethernet/microchip/sparx5/Kconfig > @@ -5,6 +5,7 @@ config SPARX5_SWITCH > depends on OF > depends on ARCH_SPARX5 || COMPILE_TEST > depends on PTP_1588_CLOCK_OPTIONAL > + depends on BRIDGE || BRIDGE=n > select PHYLINK > select PHY_SPARX5_SERDES > select RESET_CONTROLLER
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 29 Mar 2022 18:20:25 -0700 you wrote: > Fix build errors when BRIDGE=m and SPARX5_SWITCH=y: > > riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305': > sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled' > riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283': > sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled' > > [...] Here is the summary with links: - net: sparx5: uses, depends on BRIDGE or !BRIDGE https://git.kernel.org/netdev/net/c/f9512d654f62 You are awesome, thank you!
--- linux-next-20220329.orig/drivers/net/ethernet/microchip/sparx5/Kconfig +++ linux-next-20220329/drivers/net/ethernet/microchip/sparx5/Kconfig @@ -5,6 +5,7 @@ config SPARX5_SWITCH depends on OF depends on ARCH_SPARX5 || COMPILE_TEST depends on PTP_1588_CLOCK_OPTIONAL + depends on BRIDGE || BRIDGE=n select PHYLINK select PHY_SPARX5_SERDES select RESET_CONTROLLER
Fix build errors when BRIDGE=m and SPARX5_SWITCH=y: riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L305': sparx5_switchdev.c:(.text+0xdb0): undefined reference to `br_vlan_enabled' riscv64-linux-ld: drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.o: in function `.L283': sparx5_switchdev.c:(.text+0xee0): undefined reference to `br_vlan_enabled' Fixes: 3cfa11bac9bb ("net: sparx5: add the basic sparx5 driver") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Cc: Horatiu Vultur <horatiu.vultur@microchip.com> Cc: Lars Povlsen <lars.povlsen@microchip.com> Cc: Steen Hegelund <Steen.Hegelund@microchip.com> Cc: UNGLinuxDriver@microchip.com Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- drivers/net/ethernet/microchip/sparx5/Kconfig | 1 + 1 file changed, 1 insertion(+)