diff mbox series

openvswitch: Add recirc_id to recirc warning

Message ID 20220330194244.3476544-1-stgraber@ubuntu.com (mailing list archive)
State Accepted
Commit ea07af2e71cdf2c08251d8ead196ce1c9466e38c
Delegated to: Netdev Maintainers
Headers show
Series openvswitch: Add recirc_id to recirc warning | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Stéphane Graber March 30, 2022, 7:42 p.m. UTC 
When hitting the recirculation limit, the kernel would currently log
something like this:

[   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action

Which isn't all that useful to debug as we only have the interface name
to go on but can't track it down to a specific flow.

With this change, we now instead get:

[   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action (recirc_id=0x9e)

Which can now be correlated with the flow entries from OVS.

Suggested-by: Frode Nordahl <frode.nordahl@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Tested-by: Stephane Graber <stgraber@ubuntu.com>
---
 net/openvswitch/actions.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eelco Chaudron March 31, 2022, 8:28 a.m. UTC | #1 
On 30 Mar 2022, at 21:42, Stéphane Graber wrote:

> When hitting the recirculation limit, the kernel would currently log
> something like this:
>
> [   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action
>
> Which isn't all that useful to debug as we only have the interface name
> to go on but can't track it down to a specific flow.
>
> With this change, we now instead get:
>
> [   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action (recirc_id=0x9e)
>
> Which can now be correlated with the flow entries from OVS.
>
> Suggested-by: Frode Nordahl <frode.nordahl@canonical.com>
> Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
> Tested-by: Stephane Graber <stgraber@ubuntu.com>
> ---

This change looks good to me, and it makes debugging easier.

Acked-by: Eelco Chaudron <echaudro@redhat.com>

>  net/openvswitch/actions.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
> index 780d9e2246f3..7056cb1b8ba0 100644
> --- a/net/openvswitch/actions.c
> +++ b/net/openvswitch/actions.c
> @@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, struct sk_buff *skb,
>  				pr_warn("%s: deferred action limit reached, drop sample action\n",
>  					ovs_dp_name(dp));
>  			} else {  /* Recirc action */
> -				pr_warn("%s: deferred action limit reached, drop recirc action\n",
> -					ovs_dp_name(dp));
> +				pr_warn("%s: deferred action limit reached, drop recirc action (recirc_id=%#x)\n",
> +					ovs_dp_name(dp), recirc_id);
>  			}
>  		}
>  	}
> -- 
> 2.34.1
patchwork-bot+netdevbpf@kernel.org March 31, 2022, 4:20 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 30 Mar 2022 15:42:45 -0400 you wrote:
> When hitting the recirculation limit, the kernel would currently log
> something like this:
> 
> [   58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action
> 
> Which isn't all that useful to debug as we only have the interface name
> to go on but can't track it down to a specific flow.
> 
> [...]

Here is the summary with links:
  - openvswitch: Add recirc_id to recirc warning
    https://git.kernel.org/netdev/net/c/ea07af2e71cd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 780d9e2246f3..7056cb1b8ba0 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -1539,8 +1539,8 @@  static int clone_execute(struct datapath *dp, struct sk_buff *skb,
 				pr_warn("%s: deferred action limit reached, drop sample action\n",
 					ovs_dp_name(dp));
 			} else {  /* Recirc action */
-				pr_warn("%s: deferred action limit reached, drop recirc action\n",
-					ovs_dp_name(dp));
+				pr_warn("%s: deferred action limit reached, drop recirc action (recirc_id=%#x)\n",
+					ovs_dp_name(dp), recirc_id);
 			}
 		}
 	}