| Message ID | 20220401155427.3238004-1-razor@blackwall.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 692930cc435099580a4b9e32fa781b0688c18439 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: net: fix nexthop warning cleanup double ip typo | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 1 Apr 2022 18:54:27 +0300 you wrote: > I made a stupid typo when adding the nexthop route warning selftest and > added both $IP and ip after it (double ip) on the cleanup path. The > error doesn't show up when running the test, but obviously it doesn't > cleanup properly after it. > > Fixes: 392baa339c6a ("selftests: net: add delete nexthop route warning test") > Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org> > > [...] Here is the summary with links: - [net] selftests: net: fix nexthop warning cleanup double ip typo https://git.kernel.org/netdev/net/c/692930cc4350 You are awesome, thank you!
diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh index d8ede0c81ac1..b3bf5319bb0e 100755 --- a/tools/testing/selftests/net/fib_nexthops.sh +++ b/tools/testing/selftests/net/fib_nexthops.sh @@ -1220,8 +1220,8 @@ ipv4_fcnal() [ $out1 -eq $out2 ] rc=$? log_test $rc 0 "Delete nexthop route warning" - run_cmd "$IP ip route delete 172.16.101.1/32 nhid 12" - run_cmd "$IP ip nexthop del id 12" + run_cmd "$IP route delete 172.16.101.1/32 nhid 12" + run_cmd "$IP nexthop del id 12" } ipv4_grp_fcnal()
I made a stupid typo when adding the nexthop route warning selftest and added both $IP and ip after it (double ip) on the cleanup path. The error doesn't show up when running the test, but obviously it doesn't cleanup properly after it. Fixes: 392baa339c6a ("selftests: net: add delete nexthop route warning test") Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org> --- The test is accurate either way. tools/testing/selftests/net/fib_nexthops.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)