| Message ID | 20220401185304.3316-1-manishc@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 20921c0c86092b4082c91bd7c88305da74e5520b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] qed: fix ethtool register dump | expand |
On 4/1/22 12:53, Manish Chopra wrote: > To fix a coverity complain, commit d5ac07dfbd2b > ("qed: Initialize debug string array") removed "sw-platform" > (one of the common global parameters) from the dump as this > was used in the dump with an uninitialized string, however > it did not reduce the number of common global parameters > which caused the incorrect (unable to parse) register dump > > this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS > bye one. > > Cc: stable@vger.kernel.org > Cc: Tim Gardner <tim.gardner@canonical.com> > Cc: "David S. Miller" <davem@davemloft.net> > Fixes: d5ac07dfbd2b ("qed: Initialize debug string array") > Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com> > Signed-off-by: Alok Prasad <palok@marvell.com> > Signed-off-by: Ariel Elior <aelior@marvell.com> > Signed-off-by: Manish Chopra <manishc@marvell.com> > --- > drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c > index e3edca187ddf..5250d1d1e49c 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c > @@ -489,7 +489,7 @@ struct split_type_defs { > > #define STATIC_DEBUG_LINE_DWORDS 9 > > -#define NUM_COMMON_GLOBAL_PARAMS 11 > +#define NUM_COMMON_GLOBAL_PARAMS 10 > > #define MAX_RECURSION_DEPTH 10 > Looks good to me. Reviewed-by: Tim Gardner <tim.gardner@canonical.com> rtg
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 1 Apr 2022 11:53:04 -0700 you wrote: > To fix a coverity complain, commit d5ac07dfbd2b > ("qed: Initialize debug string array") removed "sw-platform" > (one of the common global parameters) from the dump as this > was used in the dump with an uninitialized string, however > it did not reduce the number of common global parameters > which caused the incorrect (unable to parse) register dump > > [...] Here is the summary with links: - [net] qed: fix ethtool register dump https://git.kernel.org/netdev/net/c/20921c0c8609 You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c index e3edca187ddf..5250d1d1e49c 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c @@ -489,7 +489,7 @@ struct split_type_defs { #define STATIC_DEBUG_LINE_DWORDS 9 -#define NUM_COMMON_GLOBAL_PARAMS 11 +#define NUM_COMMON_GLOBAL_PARAMS 10 #define MAX_RECURSION_DEPTH 10
To fix a coverity complain, commit d5ac07dfbd2b ("qed: Initialize debug string array") removed "sw-platform" (one of the common global parameters) from the dump as this was used in the dump with an uninitialized string, however it did not reduce the number of common global parameters which caused the incorrect (unable to parse) register dump this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS bye one. Cc: stable@vger.kernel.org Cc: Tim Gardner <tim.gardner@canonical.com> Cc: "David S. Miller" <davem@davemloft.net> Fixes: d5ac07dfbd2b ("qed: Initialize debug string array") Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com> Signed-off-by: Alok Prasad <palok@marvell.com> Signed-off-by: Ariel Elior <aelior@marvell.com> Signed-off-by: Manish Chopra <manishc@marvell.com> --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)