| Message ID | 20220406015921.29267-1-xiam0nd.tong@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4daf5f1956308641092769aa1924286b19513328 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] qed: remove an unneed NULL check on list iterator | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 6 Apr 2022 09:59:21 +0800 you wrote: > The define for_each_pci_dev(d) is: > while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) > > Thus, the list iterator 'd' is always non-NULL so it doesn't need to > be checked. So just remove the unnecessary NULL check. Also remove the > unnecessary initializer because the list iterator is always initialized. > > [...] Here is the summary with links: - [v2] qed: remove an unneed NULL check on list iterator https://git.kernel.org/netdev/net-next/c/4daf5f195630 You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c index 96a2077fd315..7e286cddbedb 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c +++ b/drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c @@ -161,11 +161,11 @@ EXPORT_SYMBOL(qed_vlan_get_ndev); struct pci_dev *qed_validate_ndev(struct net_device *ndev) { - struct pci_dev *pdev = NULL; struct net_device *upper; + struct pci_dev *pdev; for_each_pci_dev(pdev) { - if (pdev && pdev->driver && + if (pdev->driver && !strcmp(pdev->driver->name, "qede")) { upper = pci_get_drvdata(pdev); if (upper->ifindex == ndev->ifindex)
The define for_each_pci_dev(d) is: while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) Thus, the list iterator 'd' is always non-NULL so it doesn't need to be checked. So just remove the unnecessary NULL check. Also remove the unnecessary initializer because the list iterator is always initialized. Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> --- changes since v1: - adjust the order of variable declaration (Jakub Kicinski) v1: https://lore.kernel.org/lkml/20220405002256.22772-1-xiam0nd.tong@gmail.com/ --- drivers/net/ethernet/qlogic/qed/qed_nvmetcp_ip_services.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)