| Message ID | 20220407130423.798386-1-ytcoode@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b45043192b3e481304062938a6561da2ceea46a6 |
| Delegated to: | BPF |
| Headers | show |
| Series | [bpf-next] bpf: Fix excessive memory allocation in stack_map_alloc() | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Thu, 7 Apr 2022 21:04:23 +0800 you wrote: > The 'n_buckets * (value_size + sizeof(struct stack_map_bucket))' part of > the allocated memory for 'smap' is never used, get rid of it. > > Fixes: b936ca643ade ("bpf: rework memlock-based memory accounting for maps") > Signed-off-by: Yuntao Wang <ytcoode@gmail.com> > --- > kernel/bpf/stackmap.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [bpf-next] bpf: Fix excessive memory allocation in stack_map_alloc() https://git.kernel.org/bpf/bpf-next/c/b45043192b3e You are awesome, thank you!
diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c index 6131b4a19572..1dd5266fbebb 100644 --- a/kernel/bpf/stackmap.c +++ b/kernel/bpf/stackmap.c @@ -100,7 +100,6 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr) return ERR_PTR(-E2BIG); cost = n_buckets * sizeof(struct stack_map_bucket *) + sizeof(*smap); - cost += n_buckets * (value_size + sizeof(struct stack_map_bucket)); smap = bpf_map_area_alloc(cost, bpf_map_attr_numa_node(attr)); if (!smap) return ERR_PTR(-ENOMEM);
The 'n_buckets * (value_size + sizeof(struct stack_map_bucket))' part of the allocated memory for 'smap' is never used, get rid of it. Fixes: b936ca643ade ("bpf: rework memlock-based memory accounting for maps") Signed-off-by: Yuntao Wang <ytcoode@gmail.com> --- kernel/bpf/stackmap.c | 1 - 1 file changed, 1 deletion(-)