| Message ID | 20220411133837.318876-10-troglobit@gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bridge: forwarding of unknown IPv4/IPv6/MAC BUM traffic | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next |
On Mon, Apr 11, 2022 at 03:38:33PM +0200, Joachim Wiberg wrote: > Rename test groups to PASS and FAIL, respectively, for upcoming changes > to test suite. > > Signed-off-by: Joachim Wiberg <troglobit@gmail.com> > --- > .../selftests/net/forwarding/bridge_mdb.sh | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh b/tools/testing/selftests/net/forwarding/bridge_mdb.sh > index b1ba6876dd86..c0b84b7d4364 100755 > --- a/tools/testing/selftests/net/forwarding/bridge_mdb.sh > +++ b/tools/testing/selftests/net/forwarding/bridge_mdb.sh > @@ -7,9 +7,15 @@ > ALL_TESTS="mdb_add_del_test" > NUM_NETIFS=2 > > -TEST_GROUP_IP4="225.1.2.3" > -TEST_GROUP_IP6="ff02::42" > -TEST_GROUP_MAC="01:00:01:c0:ff:ee" > +PASS_GRP_IP4="225.1.2.3" > +FAIL_GRP_IP4="225.1.2.4" This is more than just the advertised rename, the fail groups are new and not used in this change. > + > +PASS_GRP_MAC="01:00:01:c0:ff:ee" > +FAIL_GRP_MAC="01:00:01:c0:ff:ef" > + > +PASS_GRP_IP6="ff02::42" > +FAIL_GRP_IP6="ff02::43" > + > > source lib.sh > > @@ -88,9 +94,9 @@ do_mdb_add_del() > > mdb_add_del_test() > { > - do_mdb_add_del $TEST_GROUP_MAC permanent > - do_mdb_add_del $TEST_GROUP_IP4 > - do_mdb_add_del $TEST_GROUP_IP6 > + do_mdb_add_del $PASS_GRP_MAC permanent > + do_mdb_add_del $PASS_GRP_IP4 > + do_mdb_add_del $PASS_GRP_IP6 > } > > trap cleanup EXIT > -- > 2.25.1 >
On Mon, Apr 11, 2022 at 20:23, Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > On Mon, Apr 11, 2022 at 03:38:33PM +0200, Joachim Wiberg wrote: >> -TEST_GROUP_IP4="225.1.2.3" >> -TEST_GROUP_IP6="ff02::42" >> -TEST_GROUP_MAC="01:00:01:c0:ff:ee" >> +PASS_GRP_IP4="225.1.2.3" >> +FAIL_GRP_IP4="225.1.2.4" >> +PASS_GRP_MAC="01:00:01:c0:ff:ee" >> +FAIL_GRP_MAC="01:00:01:c0:ff:ef" >> + >> +PASS_GRP_IP6="ff02::42" >> +FAIL_GRP_IP6="ff02::43" > This is more than just the advertised rename, the fail groups are new > and not used in this change. Yeah I rushed the set out to get feedback on the overall take, sorry about this. I'll see to fixing this for the non-RFC drop. Thanks!
diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb.sh b/tools/testing/selftests/net/forwarding/bridge_mdb.sh index b1ba6876dd86..c0b84b7d4364 100755 --- a/tools/testing/selftests/net/forwarding/bridge_mdb.sh +++ b/tools/testing/selftests/net/forwarding/bridge_mdb.sh @@ -7,9 +7,15 @@ ALL_TESTS="mdb_add_del_test" NUM_NETIFS=2 -TEST_GROUP_IP4="225.1.2.3" -TEST_GROUP_IP6="ff02::42" -TEST_GROUP_MAC="01:00:01:c0:ff:ee" +PASS_GRP_IP4="225.1.2.3" +FAIL_GRP_IP4="225.1.2.4" + +PASS_GRP_MAC="01:00:01:c0:ff:ee" +FAIL_GRP_MAC="01:00:01:c0:ff:ef" + +PASS_GRP_IP6="ff02::42" +FAIL_GRP_IP6="ff02::43" + source lib.sh @@ -88,9 +94,9 @@ do_mdb_add_del() mdb_add_del_test() { - do_mdb_add_del $TEST_GROUP_MAC permanent - do_mdb_add_del $TEST_GROUP_IP4 - do_mdb_add_del $TEST_GROUP_IP6 + do_mdb_add_del $PASS_GRP_MAC permanent + do_mdb_add_del $PASS_GRP_IP4 + do_mdb_add_del $PASS_GRP_IP6 } trap cleanup EXIT
Rename test groups to PASS and FAIL, respectively, for upcoming changes to test suite. Signed-off-by: Joachim Wiberg <troglobit@gmail.com> --- .../selftests/net/forwarding/bridge_mdb.sh | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)