| Message ID | 20220411172934.1813604-2-razor@blackwall.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bridge: add flush filtering support | expand |
On Mon, Apr 11, 2022 at 08:29:27PM +0300, Nikolay Aleksandrov wrote: > Add a new rtnetlink type used to flush neigh objects. It will be > initially used to add flush with filtering support for bridge fdbs, but > it also opens the door to add similar support to others (e.g. vxlan). > > Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org> > --- > include/uapi/linux/rtnetlink.h | 3 +++ > security/selinux/nlmsgtab.c | 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 83849a37db5b..06001cfd404b 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -194,6 +194,9 @@ enum { > RTM_GETTUNNEL, > #define RTM_GETTUNNEL RTM_GETTUNNEL > > + RTM_FLUSHNEIGH = 124, > +#define RTM_FLUSHNEIGH RTM_FLUSHNEIGH > + rtm message types are "new, del, get, set" quadruplets; making this a flush breaks the current consistent style. Can this be done by adding a FLUSH flag to the RTM_DELNEIGH message? > __RTM_MAX, > #define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1) > };
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index 83849a37db5b..06001cfd404b 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include/uapi/linux/rtnetlink.h @@ -194,6 +194,9 @@ enum { RTM_GETTUNNEL, #define RTM_GETTUNNEL RTM_GETTUNNEL + RTM_FLUSHNEIGH = 124, +#define RTM_FLUSHNEIGH RTM_FLUSHNEIGH + __RTM_MAX, #define RTM_MAX (((__RTM_MAX + 3) & ~3) - 1) }; diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c index d8ceee9e0d6f..ff53aea8790f 100644 --- a/security/selinux/nlmsgtab.c +++ b/security/selinux/nlmsgtab.c @@ -95,6 +95,7 @@ static const struct nlmsg_perm nlmsg_route_perms[] = { RTM_NEWTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, { RTM_DELTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, { RTM_GETTUNNEL, NETLINK_ROUTE_SOCKET__NLMSG_READ }, + { RTM_FLUSHNEIGH, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, }; static const struct nlmsg_perm nlmsg_tcpdiag_perms[] = @@ -180,7 +181,7 @@ int selinux_nlmsg_lookup(u16 sclass, u16 nlmsg_type, u32 *perm) * structures at the top of this file with the new mappings * before updating the BUILD_BUG_ON() macro! */ - BUILD_BUG_ON(RTM_MAX != (RTM_NEWTUNNEL + 3)); + BUILD_BUG_ON(RTM_MAX != (RTM_FLUSHNEIGH + 3)); err = nlmsg_perm(nlmsg_type, perm, nlmsg_route_perms, sizeof(nlmsg_route_perms)); break;
Add a new rtnetlink type used to flush neigh objects. It will be initially used to add flush with filtering support for bridge fdbs, but it also opens the door to add similar support to others (e.g. vxlan). Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org> --- include/uapi/linux/rtnetlink.h | 3 +++ security/selinux/nlmsgtab.c | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-)