| Message ID | 20220412032058.14136-1-guozhengkui@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5ee6ad1dcae8be7c101d1ffb2bbf4a01670e66cc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ipv6: exthdrs: use swap() instead of open coding it | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 12 Apr 2022 11:20:58 +0800 you wrote: > Address the following coccicheck warning: > net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap() > > by using swap() for the swapping of variable values and drop > the tmp (`addr`) variable that is not needed any more. > > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> > > [...] Here is the summary with links: - ipv6: exthdrs: use swap() instead of open coding it https://git.kernel.org/netdev/net-next/c/5ee6ad1dcae8 You are awesome, thank you!
diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 658d5eabaf7e..a2094aa1cb32 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c @@ -487,7 +487,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) struct net *net = dev_net(skb->dev); struct inet6_dev *idev; struct ipv6hdr *oldhdr; - struct in6_addr addr; unsigned char *buf; int accept_rpl_seg; int i, err; @@ -616,9 +615,7 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb) return -1; } - addr = ipv6_hdr(skb)->daddr; - ipv6_hdr(skb)->daddr = ohdr->rpl_segaddr[i]; - ohdr->rpl_segaddr[i] = addr; + swap(ipv6_hdr(skb)->daddr, ohdr->rpl_segaddr[i]); ipv6_rpl_srh_compress(chdr, ohdr, &ipv6_hdr(skb)->daddr, n);
Address the following coccicheck warning: net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap() by using swap() for the swapping of variable values and drop the tmp (`addr`) variable that is not needed any more. Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> --- net/ipv6/exthdrs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)