| Message ID | 20220418143759.85626-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1c604f91b7735a8d55ba56c8580b4b9276d6d7ab |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | myri10ge: remove redundant assignment to variable status | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 18 Apr 2022 15:37:59 +0100 you wrote: > Variable status is being assigned a value that is never read, it is > being re-assigned again later on. The assignment is redundant and can > be removed. > > Cleans up clang scan build warning: > drivers/net/ethernet/myricom/myri10ge/myri10ge.c:582:7: warning: Although > the value stored to 'status' is used in the enclosing expression, the > value is never actually read from 'status' [deadcode.DeadStores] > > [...] Here is the summary with links: - myri10ge: remove redundant assignment to variable status https://git.kernel.org/netdev/net-next/c/1c604f91b773 You are awesome, thank you!
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index 21d2645885ce..fe5e77330f5f 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -579,7 +579,7 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size) int status; unsigned i; - if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) { + if (request_firmware(&fw, mgp->fw_name, dev) < 0) { dev_err(dev, "Unable to load %s firmware image via hotplug\n", mgp->fw_name); status = -EINVAL;
Variable status is being assigned a value that is never read, it is being re-assigned again later on. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/net/ethernet/myricom/myri10ge/myri10ge.c:582:7: warning: Although the value stored to 'status' is used in the enclosing expression, the value is never actually read from 'status' [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)