| Message ID | 20220420110413.17828-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fc06b2867f4cea543505acfb194c2be4ebf0c7d3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: Add missing of_node_put() in dsa_port_link_register_of | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 20 Apr 2022 19:04:08 +0800 you wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > of_node_put() will check for NULL value. > > Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > > [...] Here is the summary with links: - net: dsa: Add missing of_node_put() in dsa_port_link_register_of https://git.kernel.org/netdev/net/c/fc06b2867f4c You are awesome, thank you!
diff --git a/net/dsa/port.c b/net/dsa/port.c index 32d472a82241..cdc56ba11f52 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -1620,8 +1620,10 @@ int dsa_port_link_register_of(struct dsa_port *dp) if (ds->ops->phylink_mac_link_down) ds->ops->phylink_mac_link_down(ds, port, MLO_AN_FIXED, PHY_INTERFACE_MODE_NA); + of_node_put(phy_np); return dsa_port_phylink_register(dp); } + of_node_put(phy_np); return 0; }
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. of_node_put() will check for NULL value. Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- net/dsa/port.c | 2 ++ 1 file changed, 2 insertions(+)