| Message ID | 20220421055344.8102-1-wupeng58@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e85f8a9f162562af1a850b9e83ec384f2b6b56aa |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: hns: Add missing fwnode_handle_put in hns_mac_init | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 21 Apr 2022 05:53:44 +0000 you wrote: > In one of the error paths of the device_for_each_child_node() loop > in hns_mac_init, add missing call to fwnode_handle_put. > > Signed-off-by: Peng Wu <wupeng58@huawei.com> > --- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Here is the summary with links: - net: hns: Add missing fwnode_handle_put in hns_mac_init https://git.kernel.org/netdev/net/c/e85f8a9f1625 You are awesome, thank you!
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c index 7edf8569514c..928d934cb21a 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c @@ -1065,19 +1065,23 @@ int hns_mac_init(struct dsaf_device *dsaf_dev) device_for_each_child_node(dsaf_dev->dev, child) { ret = fwnode_property_read_u32(child, "reg", &port_id); if (ret) { + fwnode_handle_put(child); dev_err(dsaf_dev->dev, "get reg fail, ret=%d!\n", ret); return ret; } if (port_id >= max_port_num) { + fwnode_handle_put(child); dev_err(dsaf_dev->dev, "reg(%u) out of range!\n", port_id); return -EINVAL; } mac_cb = devm_kzalloc(dsaf_dev->dev, sizeof(*mac_cb), GFP_KERNEL); - if (!mac_cb) + if (!mac_cb) { + fwnode_handle_put(child); return -ENOMEM; + } mac_cb->fw_port = child; mac_cb->mac_id = (u8)port_id; dsaf_dev->mac_cb[port_id] = mac_cb;
In one of the error paths of the device_for_each_child_node() loop in hns_mac_init, add missing call to fwnode_handle_put. Signed-off-by: Peng Wu <wupeng58@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)