| Message ID | 20220424022356.587949-3-jonathan.lemon@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Broadcom PTP PHY support | expand |
On 4/23/2022 7:23 PM, Jonathan Lemon wrote: > Add the public bcm_ptp_probe() and bcm_ptp_config_init() functions > to the bcm-phy library. The PTP functions are contained in a separate > file for clarity, and also to simplify the PTP clock dependencies. > > Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> > --- > drivers/net/phy/bcm-phy-lib.c | 13 +++++++++++++ > drivers/net/phy/bcm-phy-lib.h | 3 +++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c > index 287cccf8f7f4..b9d2d1d48402 100644 > --- a/drivers/net/phy/bcm-phy-lib.c > +++ b/drivers/net/phy/bcm-phy-lib.c > @@ -816,6 +816,19 @@ int bcm_phy_cable_test_get_status_rdb(struct phy_device *phydev, > } > EXPORT_SYMBOL_GPL(bcm_phy_cable_test_get_status_rdb); > > +#if !IS_ENABLED(CONFIG_BCM_NET_PHYPTP) > +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev) > +{ > + return NULL; > +} > +EXPORT_SYMBOL_GPL(bcm_ptp_probe); > + > +void bcm_ptp_config_init(struct phy_device *phydev) > +{ > +} > +EXPORT_SYMBOL_GPL(bcm_ptp_config_init); > +#endif I would place those in bcm-phy-lib.h instead of in bcm-phy-lib.c and have them be static inline stubs.
diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c index 287cccf8f7f4..b9d2d1d48402 100644 --- a/drivers/net/phy/bcm-phy-lib.c +++ b/drivers/net/phy/bcm-phy-lib.c @@ -816,6 +816,19 @@ int bcm_phy_cable_test_get_status_rdb(struct phy_device *phydev, } EXPORT_SYMBOL_GPL(bcm_phy_cable_test_get_status_rdb); +#if !IS_ENABLED(CONFIG_BCM_NET_PHYPTP) +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev) +{ + return NULL; +} +EXPORT_SYMBOL_GPL(bcm_ptp_probe); + +void bcm_ptp_config_init(struct phy_device *phydev) +{ +} +EXPORT_SYMBOL_GPL(bcm_ptp_config_init); +#endif + MODULE_DESCRIPTION("Broadcom PHY Library"); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Broadcom Corporation"); diff --git a/drivers/net/phy/bcm-phy-lib.h b/drivers/net/phy/bcm-phy-lib.h index c3842f87c33b..66fa731554a3 100644 --- a/drivers/net/phy/bcm-phy-lib.h +++ b/drivers/net/phy/bcm-phy-lib.h @@ -87,4 +87,7 @@ int bcm_phy_cable_test_start_rdb(struct phy_device *phydev); int bcm_phy_cable_test_start(struct phy_device *phydev); int bcm_phy_cable_test_get_status(struct phy_device *phydev, bool *finished); +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev); +void bcm_ptp_config_init(struct phy_device *phydev); + #endif /* _LINUX_BCM_PHY_LIB_H */
Add the public bcm_ptp_probe() and bcm_ptp_config_init() functions to the bcm-phy library. The PTP functions are contained in a separate file for clarity, and also to simplify the PTP clock dependencies. Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com> --- drivers/net/phy/bcm-phy-lib.c | 13 +++++++++++++ drivers/net/phy/bcm-phy-lib.h | 3 +++ 2 files changed, 16 insertions(+)