| Message ID | 20220428082848.12191-2-josua@solid-run.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | adin: add support for clock output | expand |
Hi Shawn, Thank you for looking at patch 3 in this series, in case you missed it - the adi,phy-output-clock property does not yet exist in bindings, I am trying to get that one added. Am 28.04.22 um 11:28 schrieb Josua Mayer: > The ADIN1300 supports generating certain clocks on its GP_CLK pin, as > well as providing the reference clock on CLK25_REF. > > Add DT properties to configure both pins. > > Signed-off-by: Josua Mayer <josua@solid-run.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > V1 -> V2: changed clkout property to enum > V1 -> V2: added property for CLK25_REF pin > > .../devicetree/bindings/net/adi,adin.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml > index 1129f2b58e98..3e0c6304f190 100644 > --- a/Documentation/devicetree/bindings/net/adi,adin.yaml > +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml > @@ -36,6 +36,23 @@ properties: > enum: [ 4, 8, 12, 16, 20, 24 ] > default: 8 > > + adi,phy-output-clock: > + description: Select clock output on GP_CLK pin. Three clocks are available: > + A 25MHz reference, a free-running 125MHz and a recovered 125MHz. > + The phy can also automatically switch between the reference and the > + respective 125MHz clocks based on its internal state. > + $ref: /schemas/types.yaml#/definitions/string > + enum: > + - 25mhz-reference > + - 125mhz-free-running > + - 125mhz-recovered > + - adaptive-free-running > + - adaptive-recovered > + > + adi,phy-output-reference-clock: > + description: Enable 25MHz reference clock output on CLK25_REF pin. > + $ref: /schemas/types.yaml#/definitions/flag > + > unevaluatedProperties: false > > examples: - Josua Mayer
On 28/04/2022 10:28, Josua Mayer wrote: Thank you for your patch. There is something to discuss/improve. > > diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml > index 1129f2b58e98..3e0c6304f190 100644 > --- a/Documentation/devicetree/bindings/net/adi,adin.yaml > +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml > @@ -36,6 +36,23 @@ properties: > enum: [ 4, 8, 12, 16, 20, 24 ] > default: 8 > > + adi,phy-output-clock: > + description: Select clock output on GP_CLK pin. Three clocks are available: > + A 25MHz reference, a free-running 125MHz and a recovered 125MHz. > + The phy can also automatically switch between the reference and the > + respective 125MHz clocks based on its internal state. > + $ref: /schemas/types.yaml#/definitions/string > + enum: > + - 25mhz-reference > + - 125mhz-free-running > + - 125mhz-recovered > + - adaptive-free-running > + - adaptive-recovered Missing two spaces of indentation for all these items. > + > + adi,phy-output-reference-clock: > + description: Enable 25MHz reference clock output on CLK25_REF pin. > + $ref: /schemas/types.yaml#/definitions/flag This could be just "type:boolean". Best regards, Krzysztof
\o/ Am 05.05.22 um 23:24 schrieb Krzysztof Kozlowski: > On 28/04/2022 10:28, Josua Mayer wrote: > > Thank you for your patch. There is something to discuss/improve. Thank you for taking a look. >> diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml >> index 1129f2b58e98..3e0c6304f190 100644 >> --- a/Documentation/devicetree/bindings/net/adi,adin.yaml >> +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml >> @@ -36,6 +36,23 @@ properties: >> enum: [ 4, 8, 12, 16, 20, 24 ] >> default: 8 >> >> + adi,phy-output-clock: >> + description: Select clock output on GP_CLK pin. Three clocks are available: >> + A 25MHz reference, a free-running 125MHz and a recovered 125MHz. >> + The phy can also automatically switch between the reference and the >> + respective 125MHz clocks based on its internal state. >> + $ref: /schemas/types.yaml#/definitions/string >> + enum: >> + - 25mhz-reference >> + - 125mhz-free-running >> + - 125mhz-recovered >> + - adaptive-free-running >> + - adaptive-recovered > Missing two spaces of indentation for all these items. Will add in v4, thank you. > >> + >> + adi,phy-output-reference-clock: >> + description: Enable 25MHz reference clock output on CLK25_REF pin. >> + $ref: /schemas/types.yaml#/definitions/flag > This could be just "type:boolean". Yes, it could be boolean, and default to false. So ... I figured its a flag, but whether to make it a flag or boolean is better I do not know. > Best regards, > Krzysztof sincerely - Josua Mayer
On 08/05/2022 11:57, Josua Mayer wrote: >>> + adi,phy-output-reference-clock: >>> + description: Enable 25MHz reference clock output on CLK25_REF pin. >>> + $ref: /schemas/types.yaml#/definitions/flag >> This could be just "type:boolean". > Yes, it could be boolean, and default to false. > So ... I figured its a flag, but whether to make it a flag or boolean is > better I do not know. As I said, use "type:boolean", less typing and it is equivalent. Best regards, Krzysztof
Am 05.05.22 um 23:24 schrieb Krzysztof Kozlowski: > On 28/04/2022 10:28, Josua Mayer wrote: > > Thank you for your patch. There is something to discuss/improve. > >> diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml >> index 1129f2b58e98..3e0c6304f190 100644 >> --- a/Documentation/devicetree/bindings/net/adi,adin.yaml >> +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml >> @@ -36,6 +36,23 @@ properties: >> enum: [ 4, 8, 12, 16, 20, 24 ] >> default: 8 >> >> + adi,phy-output-clock: >> + description: Select clock output on GP_CLK pin. Three clocks are available: >> + A 25MHz reference, a free-running 125MHz and a recovered 125MHz. >> + The phy can also automatically switch between the reference and the >> + respective 125MHz clocks based on its internal state. >> + $ref: /schemas/types.yaml#/definitions/string >> + enum: >> + - 25mhz-reference >> + - 125mhz-free-running >> + - 125mhz-recovered >> + - adaptive-free-running >> + - adaptive-recovered > Missing two spaces of indentation for all these items. > >> + >> + adi,phy-output-reference-clock: >> + description: Enable 25MHz reference clock output on CLK25_REF pin. >> + $ref: /schemas/types.yaml#/definitions/flag > This could be just "type:boolean". I will change it accordingly, thanks. > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/net/adi,adin.yaml b/Documentation/devicetree/bindings/net/adi,adin.yaml index 1129f2b58e98..3e0c6304f190 100644 --- a/Documentation/devicetree/bindings/net/adi,adin.yaml +++ b/Documentation/devicetree/bindings/net/adi,adin.yaml @@ -36,6 +36,23 @@ properties: enum: [ 4, 8, 12, 16, 20, 24 ] default: 8 + adi,phy-output-clock: + description: Select clock output on GP_CLK pin. Three clocks are available: + A 25MHz reference, a free-running 125MHz and a recovered 125MHz. + The phy can also automatically switch between the reference and the + respective 125MHz clocks based on its internal state. + $ref: /schemas/types.yaml#/definitions/string + enum: + - 25mhz-reference + - 125mhz-free-running + - 125mhz-recovered + - adaptive-free-running + - adaptive-recovered + + adi,phy-output-reference-clock: + description: Enable 25MHz reference clock output on CLK25_REF pin. + $ref: /schemas/types.yaml#/definitions/flag + unevaluatedProperties: false examples: