From patchwork Sun May 8 22:48:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hauke Mehrtens X-Patchwork-Id: 12842962 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B47C433F5 for ; Sun, 8 May 2022 22:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233398AbiEHWxa (ORCPT ); Sun, 8 May 2022 18:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbiEHWx3 (ORCPT ); Sun, 8 May 2022 18:53:29 -0400 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [IPv6:2001:67c:2050:0:465::101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A64C03896 for ; Sun, 8 May 2022 15:49:36 -0700 (PDT) Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4KxKHd2hGQz9sQp; Mon, 9 May 2022 00:49:33 +0200 (CEST) From: Hauke Mehrtens DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hauke-m.de; s=MBO0001; t=1652050171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w15Bl0kWKh9ytJ0DDSsmIBoP7JeJ85M+oT79ZYhI1hg=; b=TUCCIe8TFGF0OdV6A21Ddz7RuDjVrQzWVHx03Fr3XUzMlcj+X3c0FdqXj3uumOg+U32PkS 3ep1cmWZ4zE12NnO5jEG66UxK4wwmN4C315vgp28kADseVDKE1wH3kF/JNlpFsKeCjLh2F kUipEKQwO7X0Z2jIR6jmtD0fUPyjRtr443SK4ymzE+GLEW2P024FE6jC2soauHdlRWsPRR 2iL5myc/Ug2YpkcgfO6B4h5EgwUMYlDCdTCyZOhNPCs6CiUFV3w1yDfKkaDyasV3XWb4d3 GO50wmmrcr/GZdIGb7UK5ABSAvmt1tWVkNMndMd/EQWIcuQsU9zR8v/4PNwWNw== To: davem@davemloft.net, kuba@kernel.org Cc: linus.walleij@linaro.org, alsi@bang-olufsen.dk, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org, Hauke Mehrtens Subject: [PATCH 1/4] net: dsa: realtek: rtl8365mb: Fix interface type mask Date: Mon, 9 May 2022 00:48:45 +0200 Message-Id: <20220508224848.2384723-2-hauke@hauke-m.de> In-Reply-To: <20220508224848.2384723-1-hauke@hauke-m.de> References: <20220508224848.2384723-1-hauke@hauke-m.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The mask should be shifted like the offset. Signed-off-by: Hauke Mehrtens Reviewed-by: Alvin Šipraga --- drivers/net/dsa/realtek/rtl8365mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 3d70e8a77ecf..2cb722a9e096 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -237,7 +237,7 @@ static const int rtl8365mb_extint_port_map[] = { -1, -1, -1, -1, -1, -1, 1, 2, (_extint) == 2 ? RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1 : \ 0x0) #define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extint) \ - (0xF << (((_extint) % 2))) + (0xF << (((_extint) % 2) * 4)) #define RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_OFFSET(_extint) \ (((_extint) % 2) * 4)