diff mbox series

[PATCHv3,bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile

Message ID 20220516040020.653291-1-liuhangbin@gmail.com (mailing list archive)
State Accepted
Commit 70a1b25326dd77e145157ccf1a31c1948032eec4
Delegated to: BPF
Headers show
Series [PATCHv3,bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR success PR summary
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 2 blamed authors not CCed: yhs@fb.com kpsingh@kernel.org; 7 maintainers not CCed: kafai@fb.com john.fastabend@gmail.com shuah@kernel.org yhs@fb.com kpsingh@kernel.org linux-kselftest@vger.kernel.org songliubraving@fb.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-1 success Logs for Kernel LATEST on ubuntu-latest with gcc
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Kernel LATEST on ubuntu-latest with llvm-15
bpf/vmtest-bpf-next-VM_Test-3 success Logs for Kernel LATEST on z15 with gcc

Commit Message

Hangbin Liu May 16, 2022, 4 a.m. UTC
When build bpf test and install it to another folder, e.g.

  make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests

The ima_setup.sh is missed in target folder, which makes test_ima failed.

Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.

Fixes: 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v3: rebase code to latest bpf-next, and drop the second patch
v2: fix subject prefix from net to bpf-next
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yonghong Song May 17, 2022, 3:15 a.m. UTC | #1
On 5/15/22 9:00 PM, Hangbin Liu wrote:
> When build bpf test and install it to another folder, e.g.
> 
>    make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
> 	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests
> 
> The ima_setup.sh is missed in target folder, which makes test_ima failed.
> 
> Fix it by adding ima_setup.sh to TEST_PROGS_EXTENDED.
> 
> Fixes: 34b82d3ac105 ("bpf: Add a selftest for bpf_ima_inode_hash")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Acked-by: Yonghong Song <yhs@fb.com>
patchwork-bot+netdevbpf@kernel.org May 19, 2022, 12:20 a.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon, 16 May 2022 12:00:20 +0800 you wrote:
> When build bpf test and install it to another folder, e.g.
> 
>   make -j10 install -C tools/testing/selftests/ TARGETS="bpf" \
> 	SKIP_TARGETS="" INSTALL_PATH=/tmp/kselftests
> 
> The ima_setup.sh is missed in target folder, which makes test_ima failed.
> 
> [...]

Here is the summary with links:
  - [PATCHv3,bpf-next] selftests/bpf: add missed ima_setup.sh in Makefile
    https://git.kernel.org/bpf/bpf-next/c/70a1b25326dd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 6bbc03161544..74dda54e88c4 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -75,7 +75,7 @@  TEST_PROGS := test_kmod.sh \
 	test_xsk.sh
 
 TEST_PROGS_EXTENDED := with_addr.sh \
-	with_tunnels.sh \
+	with_tunnels.sh ima_setup.sh \
 	test_xdp_vlan.sh test_bpftool.py
 
 # Compile but not part of 'make run_tests'