From patchwork Sat May 21 20:47:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12858032 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56517C433EF for ; Sat, 21 May 2022 20:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344206AbiEUUre (ORCPT ); Sat, 21 May 2022 16:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239520AbiEUUrc (ORCPT ); Sat, 21 May 2022 16:47:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3AB9041302 for ; Sat, 21 May 2022 13:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653166051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Q7KKV9nEc1O8xO71RHJAseDwiXENbXZxnjAzbqBmERg=; b=CfDl3F5+X8uxUS6h6/i8oHDDJAEfZrUUTZIqq6jqMjW/ikVt8WUTXYJLl+uTE26ivszCvF MliR3+tK7oFb8TpYt23anAs8h1jvZuvFmMFnuWhJtHY3D0pRW7PmGDxatZgGkNNhCgu9U9 Uzu6mb1sLO77eb7eu3q2Y2MLSgqGQwc= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-HMQSlLUcNmSfOJuR3qtNWw-1; Sat, 21 May 2022 16:47:30 -0400 X-MC-Unique: HMQSlLUcNmSfOJuR3qtNWw-1 Received: by mail-oo1-f71.google.com with SMTP id j15-20020a4a888f000000b00321764d8f14so5415485ooa.14 for ; Sat, 21 May 2022 13:47:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q7KKV9nEc1O8xO71RHJAseDwiXENbXZxnjAzbqBmERg=; b=0iwhBxfRRNGhRfK9/K6FrJdJIcqdoHHjaN+oin8c6qNjKIDTLkzQOIQ2jNs71wTJdd aSGl92z2YesdPtxpn7lZ9yXXBL+CZ2AN7dXpMQ7uTwq7X7hPZLA0LJVY01ki2zvzTNRl +2FOqhSa5HIEjHPnozzZq3AefNVcgDZPZhn7hAbWbpYD58VIvvvYj2g3uwdq5R59sMr9 uUIb/RWmENcNIvlH7JKT1L9ulYb/eT94Jy7V8H69ZVMp6LrVqqrONp61xuxtXnA83v3N K4+R0ffEjA7qMwvsy2JRhqjHy/X83TvWMSJAV7yTpIvjhEBkwZiEnpWFGFwesF5M5XJi GdzQ== X-Gm-Message-State: AOAM531G+ZgFOLjsDG96ypvJVd2PUzngyDSmUg8sMD6QbzjheCSxE95p eu0DvaLlgXfGghjoy8XB+Gg2oANEVd+Ssu8K0G4VmN9vLdYS4kiiorDd0GX3t8D0d4ewmSDweWe xEQ2M+P5HZ9FajLCJ X-Received: by 2002:a05:6870:5694:b0:f2:2ad8:a0ae with SMTP id p20-20020a056870569400b000f22ad8a0aemr2596741oao.71.1653166049069; Sat, 21 May 2022 13:47:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXZGmjsHsgboy8HLVJI93WiKGJ0RPTYTp8bJj+9c19UnhE7jTtNQ/lroFEhDPgmTztujXLFg== X-Received: by 2002:a05:6870:5694:b0:f2:2ad8:a0ae with SMTP id p20-20020a056870569400b000f22ad8a0aemr2596738oao.71.1653166048917; Sat, 21 May 2022 13:47:28 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id d44-20020a056870d2ac00b000f218150563sm1751520oae.10.2022.05.21.13.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 May 2022 13:47:28 -0700 (PDT) From: Tom Rix To: toke@toke.dk, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] ath9k: remove setting of 'is_ext' parameter Date: Sat, 21 May 2022 16:47:25 -0400 Message-Id: <20220521204725.2539952-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org cppcheck reports [drivers/net/wireless/ath/ath9k/dfs.c:93]: (style) Assignment of function parameter has no effect outside the function. Both the is_ctl and the is_ext parameters are set in the if-else statement. But only is_ctl is used later, so setting is_ext is not needed and can be removed. Signed-off-by: Tom Rix --- drivers/net/wireless/ath/ath9k/dfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c b/drivers/net/wireless/ath/ath9k/dfs.c index acb9602aa464..47cdfb584eb0 100644 --- a/drivers/net/wireless/ath/ath9k/dfs.c +++ b/drivers/net/wireless/ath/ath9k/dfs.c @@ -89,8 +89,6 @@ static int ath9k_get_max_index_ht40(struct ath9k_dfs_fft_40 *fft, int mag_upper = fft_max_magnitude(fft->upper_bins); if (mag_upper > mag_lower) is_ctl = false; - else - is_ext = false; } } if (is_ctl)