| Message ID | 20220522133627.4085200-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a11fb1d1b8501c430472c66ea5390cb719bbd8f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: fddi: skfp: smt: Remove extra parameters to vararg macro | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 22 May 2022 09:36:27 -0400 you wrote: > cppcheck reports > [drivers/net/fddi/skfp/smt.c:750]: (warning) printf format string requires 0 parameters but 2 are given. > > DB_SBAN is a vararg macro, like DB_ESSN. Remove the extra args and the nl. > > Signed-off-by: Tom Rix <trix@redhat.com> > > [...] Here is the summary with links: - net: fddi: skfp: smt: Remove extra parameters to vararg macro https://git.kernel.org/netdev/net-next/c/2a11fb1d1b85 You are awesome, thank you!
diff --git a/drivers/net/fddi/skfp/smt.c b/drivers/net/fddi/skfp/smt.c index 72c31f0013ad..dd15af4e98c2 100644 --- a/drivers/net/fddi/skfp/smt.c +++ b/drivers/net/fddi/skfp/smt.c @@ -747,7 +747,7 @@ void smt_received_pack(struct s_smc *smc, SMbuf *mb, int fs) #endif #ifdef SBA - DB_SBAN(2,"SBA: RAF frame received\n",0,0) ; + DB_SBAN(2, "SBA: RAF frame received") ; sba_raf_received_pack(smc,sm,fs) ; #endif break ;
cppcheck reports [drivers/net/fddi/skfp/smt.c:750]: (warning) printf format string requires 0 parameters but 2 are given. DB_SBAN is a vararg macro, like DB_ESSN. Remove the extra args and the nl. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/fddi/skfp/smt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)