diff mbox series

amt: remove unnecessary (void*) conversions.

Message ID 20220621021648.2544-1-yuzhe@nfschina.com (mailing list archive)
State Accepted
Commit d13a3205a7175d673d5080ddf155dc69aad6085c
Delegated to: Netdev Maintainers
Headers show
Series amt: remove unnecessary (void*) conversions. | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/cc_maintainers success CCed 6 of 6 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 26 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Yu Zhe June 21, 2022, 2:16 a.m. UTC 
remove unnecessary void* type castings.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
---
 drivers/net/amt.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski June 22, 2022, 5:26 a.m. UTC | #1 
On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>

Taehee, ack?  Your call.
Taehee Yoo June 22, 2022, 6:26 a.m. UTC | #2 
Hi Yu Zhe,
Thanks a lot for your work!

On 6/22/22 14:26, Jakub Kicinski wrote:
> On Tue, 21 Jun 2022 10:16:48 +0800 Yu Zhe wrote:
>> remove unnecessary void* type castings.
>>
>> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> 
> Taehee, ack?  Your call.

Hi Jakub,

It looks good to me.
I tested this and It works well.

Thanks a lot!

Acked-by: Taehee Yoo <ap420073@gmail.com>
patchwork-bot+netdevbpf@kernel.org June 23, 2022, 12:40 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 21 Jun 2022 10:16:48 +0800 you wrote:
> remove unnecessary void* type castings.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/net/amt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Here is the summary with links:
  - amt: remove unnecessary (void*) conversions.
    https://git.kernel.org/netdev/net-next/c/d13a3205a717

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index be2719a3ba70..732f4c0daa73 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -1373,11 +1373,11 @@  static void amt_add_srcs(struct amt_dev *amt, struct amt_tunnel_list *tunnel,
 	int i;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;
@@ -1458,11 +1458,11 @@  static void amt_lookup_act_srcs(struct amt_tunnel_list *tunnel,
 	int i, j;
 
 	if (!v6) {
-		igmp_grec = (struct igmpv3_grec *)grec;
+		igmp_grec = grec;
 		nsrcs = ntohs(igmp_grec->grec_nsrcs);
 	} else {
 #if IS_ENABLED(CONFIG_IPV6)
-		mld_grec = (struct mld2_grec *)grec;
+		mld_grec = grec;
 		nsrcs = ntohs(mld_grec->grec_nsrcs);
 #else
 	return;