| Message ID | 20220623074615.56418-4-vbhadram@nvidia.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1,1/9] dt-bindings: power: Add Tegra234 MGBE power domains | expand |
On Thu, 23 Jun 2022 13:16:10 +0530, Bhadram Varka wrote: > From: Thierry Reding <treding@nvidia.com> > > Tegra234 has multiple network interfaces with each their own memory > clients and stream IDs to allow for proper isolation. > > Applied, thanks! [4/9] memory: tegra: Add MGBE memory clients for Tegra234 https://git.kernel.org/krzk/linux-mem-ctrl/c/6b36629c85dc7d4551e57e92a3e970d099333e4e Best regards,
On Fri, Jun 24, 2022 at 06:06:35PM +0200, Krzysztof Kozlowski wrote: > On Thu, 23 Jun 2022 13:16:10 +0530, Bhadram Varka wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Tegra234 has multiple network interfaces with each their own memory > > clients and stream IDs to allow for proper isolation. > > > > > > Applied, thanks! > > [4/9] memory: tegra: Add MGBE memory clients for Tegra234 > https://git.kernel.org/krzk/linux-mem-ctrl/c/6b36629c85dc7d4551e57e92a3e970d099333e4e Ah yes, you'll need the dt-bindings header for this driver bit as well. If you don't mind I could pick all of these up into the Tegra tree and resolve the dependencies there, then send a pull request for the memory tree that incorporates the dt-bindings branch as a dependency. That way you don't have to worry about this at all. We might also get another set of similar changes for PCI or USB during this cycle, so it'd certainly be easier to collect all of these in a central place. Thierry
On 24/06/2022 18:24, Thierry Reding wrote: > On Fri, Jun 24, 2022 at 06:06:35PM +0200, Krzysztof Kozlowski wrote: >> On Thu, 23 Jun 2022 13:16:10 +0530, Bhadram Varka wrote: >>> From: Thierry Reding <treding@nvidia.com> >>> >>> Tegra234 has multiple network interfaces with each their own memory >>> clients and stream IDs to allow for proper isolation. >>> >>> >> >> Applied, thanks! >> >> [4/9] memory: tegra: Add MGBE memory clients for Tegra234 >> https://git.kernel.org/krzk/linux-mem-ctrl/c/6b36629c85dc7d4551e57e92a3e970d099333e4e > > Ah yes, you'll need the dt-bindings header for this driver bit as well. > If you don't mind I could pick all of these up into the Tegra tree and > resolve the dependencies there, then send a pull request for the memory > tree that incorporates the dt-bindings branch as a dependency. > > That way you don't have to worry about this at all. We might also get > another set of similar changes for PCI or USB during this cycle, so it'd > certainly be easier to collect all of these in a central place. I cannot take DTS patches to the driver tree, so it's easier if you take it and handle the dependencies. Best regards, Krzysztof
On 23/06/2022 09:46, Bhadram Varka wrote: > From: Thierry Reding <treding@nvidia.com> > > Tegra234 has multiple network interfaces with each their own memory > clients and stream IDs to allow for proper isolation. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > Signed-off-by: Bhadram Varka <vbhadram@nvidia.com> > --- > drivers/memory/tegra/tegra234.c | 80 +++++++++++++++++++++++++++++++++ > 1 file changed, 80 insertions(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Dropped from my tree. Best regards, Krzysztof
diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra234.c index e23ebd421f17..a9e8fd99730f 100644 --- a/drivers/memory/tegra/tegra234.c +++ b/drivers/memory/tegra/tegra234.c @@ -11,6 +11,76 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { { + .id = TEGRA234_MEMORY_CLIENT_MGBEARD, + .name = "mgbeard", + .sid = TEGRA234_SID_MGBE, + .regs = { + .sid = { + .override = 0x2c0, + .security = 0x2c4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBEBRD, + .name = "mgbebrd", + .sid = TEGRA234_SID_MGBE_VF1, + .regs = { + .sid = { + .override = 0x2c8, + .security = 0x2cc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBECRD, + .name = "mgbecrd", + .sid = TEGRA234_SID_MGBE_VF2, + .regs = { + .sid = { + .override = 0x2d0, + .security = 0x2d4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBEDRD, + .name = "mgbedrd", + .sid = TEGRA234_SID_MGBE_VF3, + .regs = { + .sid = { + .override = 0x2d8, + .security = 0x2dc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBEAWR, + .name = "mgbeawr", + .sid = TEGRA234_SID_MGBE, + .regs = { + .sid = { + .override = 0x2e0, + .security = 0x2e4, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBEBWR, + .name = "mgbebwr", + .sid = TEGRA234_SID_MGBE_VF1, + .regs = { + .sid = { + .override = 0x2f8, + .security = 0x2fc, + }, + }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBECWR, + .name = "mgbecwr", + .sid = TEGRA234_SID_MGBE_VF2, + .regs = { + .sid = { + .override = 0x308, + .security = 0x30c, + }, + }, + }, { .id = TEGRA234_MEMORY_CLIENT_SDMMCRAB, .name = "sdmmcrab", .sid = TEGRA234_SID_SDMMC4, @@ -20,6 +90,16 @@ static const struct tegra_mc_client tegra234_mc_clients[] = { .security = 0x31c, }, }, + }, { + .id = TEGRA234_MEMORY_CLIENT_MGBEDWR, + .name = "mgbedwr", + .sid = TEGRA234_SID_MGBE_VF3, + .regs = { + .sid = { + .override = 0x328, + .security = 0x32c, + }, + }, }, { .id = TEGRA234_MEMORY_CLIENT_SDMMCWAB, .name = "sdmmcwab",