From patchwork Thu Jun 23 08:51:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enguerrand de Ribaucourt X-Patchwork-Id: 12891943 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D978C43334 for ; Thu, 23 Jun 2022 08:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbiFWIvm (ORCPT ); Thu, 23 Jun 2022 04:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbiFWIvl (ORCPT ); Thu, 23 Jun 2022 04:51:41 -0400 Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13CE449684; Thu, 23 Jun 2022 01:51:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 75E329C0212; Thu, 23 Jun 2022 04:51:40 -0400 (EDT) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BRJZWFlrwMuP; Thu, 23 Jun 2022 04:51:39 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id BE5B79C021C; Thu, 23 Jun 2022 04:51:39 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com BE5B79C021C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1655974299; bh=2W+lIf6qQ2lUkL8+3ZiA5lGY3Srk9AN/ouUZgnymuxg=; h=From:To:Date:Message-Id:MIME-Version; b=xxx9j6SqxljwMTUG14rTFJRiCrEkL8ke7ZwfH42DhaKtPNEMUDQz5pr541sVYhpS1 WzUYuV1cK3OkwiAXxzerGJ10LS39cboZ4yASlFVPEvF/gpBaqeQrrTlynIrIdrJk4y NPuuUrWTvkPG7JHuo4eIP/Yei+G7wzpy8BBCWmRsZQMkIKho99zV5Talvs/EhDVQcC vmBpPasAGMHHzXmubnLeAwzL0oaMA9e0IeFDQV+Wpp+YyfyTufymFoayFRqsGH7mk/ B0anC3jM5R00+CUL+mIy5aYf0ebJQadWF4GPoKpIJXbFrou4azvMGDmcd7ptvYGlaB 3vB5kIWLwHHsA== X-Virus-Scanned: amavisd-new at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5alfUzC5GCWU; Thu, 23 Jun 2022 04:51:39 -0400 (EDT) Received: from sfl-deribaucourt.rennes.sfl (lfbn-ren-1-676-174.w81-53.abo.wanadoo.fr [81.53.245.174]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id BA4269C0212; Thu, 23 Jun 2022 04:51:38 -0400 (EDT) From: Enguerrand de Ribaucourt To: andrew@lunn.ch Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, hkallweit1@gmail.com, Enguerrand de Ribaucourt Subject: [PATCH 1/2] net: dp83822: disable false carrier interrupt Date: Thu, 23 Jun 2022 10:51:25 +0200 Message-Id: <20220623085125.1426049-1-enguerrand.de-ribaucourt@savoirfairelinux.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org When unplugging an Ethernet cable, false carrier events were produced by the PHY at a very high rate. Once the false carrier counter full, an interrupt was triggered every few clock cycles until the cable was replugged. This resulted in approximately 10k/s interrupts. Since the false carrier counter (FCSCR) is never used, we can safely disable this interrupt. In addition to improving performance, this also solved MDIO read timeouts I was randomly encountering with an i.MX8 fec MAC because of the interrupt flood. The interrupt count and MDIO timeout fix were tested on a v5.4.110 kernel. Signed-off-by: Enguerrand de Ribaucourt Reviewed-by: Andrew Lunn --- drivers/net/phy/dp83822.c | 1 - 1 file changed, 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index e6ad3a494d32..95ef507053a6 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -230,7 +230,6 @@ static int dp83822_config_intr(struct phy_device *phydev) return misr_status; misr_status |= (DP83822_RX_ERR_HF_INT_EN | - DP83822_FALSE_CARRIER_HF_INT_EN | DP83822_LINK_STAT_INT_EN | DP83822_ENERGY_DET_INT_EN | DP83822_LINK_QUAL_INT_EN);