Message ID | 20220623134645.1858361-2-enguerrand.de-ribaucourt@savoirfairelinux.com (mailing list archive) |
---|---|
State | Accepted |
Commit | c96614eeab663646f57f67aa591e015abd8bd0ba |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: dp83822: fix interrupt floods | expand |
On Thu, Jun 23, 2022 at 03:46:44PM +0200, Enguerrand de Ribaucourt wrote: > When unplugging an Ethernet cable, false carrier events were produced by > the PHY at a very high rate. Once the false carrier counter full, an > interrupt was triggered every few clock cycles until the cable was > replugged. This resulted in approximately 10k/s interrupts. > > Since the false carrier counter (FCSCR) is never used, we can safely > disable this interrupt. > > In addition to improving performance, this also solved MDIO read > timeouts I was randomly encountering with an i.MX8 fec MAC because of > the interrupt flood. The interrupt count and MDIO timeout fix were > tested on a v5.4.110 kernel. > > Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission") For future reference, you should put these in the opposite order. Your Signed-off-by should come last. Fixes generally comes first. No need to resend for this patchset. Andrew
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index e6ad3a494d32..95ef507053a6 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -230,7 +230,6 @@ static int dp83822_config_intr(struct phy_device *phydev) return misr_status; misr_status |= (DP83822_RX_ERR_HF_INT_EN | - DP83822_FALSE_CARRIER_HF_INT_EN | DP83822_LINK_STAT_INT_EN | DP83822_ENERGY_DET_INT_EN | DP83822_LINK_QUAL_INT_EN);