| Message ID | 20220624101758.565822-1-ioana.ciornei@nxp.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: pcs: pcs-xpcs: hide xpcs Kconfig option from the user | expand |
On Fri, 24 Jun 2022 13:17:58 +0300 Ioana Ciornei wrote: > Hide the xpcs Kconfig option from the user so that we do not end up in > a scenario where the xpcs is enabled as a module but phylink is not > enabled at all. > > ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined! > ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined! > > All the user drivers (stmmac and sja1105) of the xpcs module already > select both PCS_XPCS and PHYLINK, so the dependency is resolved at that > level. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support") > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> Oh, somehow I missed this patch on Friday, I applied my own commit ebeae54d3a77 ("net: pcs: xpcs: depends on PHYLINK in Kconfig")
diff --git a/drivers/net/pcs/Kconfig b/drivers/net/pcs/Kconfig index 22ba7b0b476d..9eb32220efea 100644 --- a/drivers/net/pcs/Kconfig +++ b/drivers/net/pcs/Kconfig @@ -6,7 +6,7 @@ menu "PCS device drivers" config PCS_XPCS - tristate "Synopsys DesignWare XPCS controller" + tristate depends on MDIO_DEVICE && MDIO_BUS help This module provides helper functions for Synopsys DesignWare XPCS
Hide the xpcs Kconfig option from the user so that we do not end up in a scenario where the xpcs is enabled as a module but phylink is not enabled at all. ERROR: modpost: "phylink_mii_c22_pcs_encode_advertisement" [drivers/net/pcs/pcs_xpcs.ko] undefined! ERROR: modpost: "phylink_mii_c22_pcs_decode_state" [drivers/net/pcs/pcs_xpcs.ko] undefined! All the user drivers (stmmac and sja1105) of the xpcs module already select both PCS_XPCS and PHYLINK, so the dependency is resolved at that level. Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: b47aec885bcd ("net: pcs: xpcs: add CL37 1000BASE-X AN support") Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com> --- drivers/net/pcs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)