Message ID | 20220626152703.18157-1-o.rempel@pengutronix.de (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next,v2,1/1] net: phy: ax88772a: fix lost pause advertisement configuration | expand |
On Sun, Jun 26, 2022 at 05:27:03PM +0200, Oleksij Rempel wrote: > In case of asix_ax88772a_link_change_notify() workaround, we run soft > reset which will automatically clear MII_ADVERTISE configuration. The > PHYlib framework do not know about changed configuration state of the > PHY, so we need use phy_init_hw() to reinit PHY configuration. > > Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Sun, 26 Jun 2022 17:27:03 +0200 Oleksij Rempel wrote: > Subject: [PATCH net-next v2 1/1] net: phy: ax88772a: fix lost pause advertisement configuration > > In case of asix_ax88772a_link_change_notify() workaround, we run soft > reset which will automatically clear MII_ADVERTISE configuration. The > PHYlib framework do not know about changed configuration state of the > PHY, so we need use phy_init_hw() to reinit PHY configuration. > > Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") Why net-next?
On Mon, Jun 27, 2022 at 10:17:05PM -0700, Jakub Kicinski wrote: > On Sun, 26 Jun 2022 17:27:03 +0200 Oleksij Rempel wrote: > > Subject: [PATCH net-next v2 1/1] net: phy: ax88772a: fix lost pause advertisement configuration > > > > In case of asix_ax88772a_link_change_notify() workaround, we run soft > > reset which will automatically clear MII_ADVERTISE configuration. The > > PHYlib framework do not know about changed configuration state of the > > PHY, so we need use phy_init_hw() to reinit PHY configuration. > > > > Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") > > Why net-next? It is old bug but it will be notable only after this patch: https://lore.kernel.org/all/20220624080208.3143093-1-o.rempel@pengutronix.de/ Should I resend it to net? Regards, Oleksij
On Tue, 2022-06-28 at 08:43 +0200, Oleksij Rempel wrote: > On Mon, Jun 27, 2022 at 10:17:05PM -0700, Jakub Kicinski wrote: > > On Sun, 26 Jun 2022 17:27:03 +0200 Oleksij Rempel wrote: > > > Subject: [PATCH net-next v2 1/1] net: phy: ax88772a: fix lost pause advertisement configuration > > > > > > In case of asix_ax88772a_link_change_notify() workaround, we run soft > > > reset which will automatically clear MII_ADVERTISE configuration. The > > > PHYlib framework do not know about changed configuration state of the > > > PHY, so we need use phy_init_hw() to reinit PHY configuration. > > > > > > Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") > > > > Why net-next? > > It is old bug but it will be notable only after this patch: > https://lore.kernel.org/all/20220624080208.3143093-1-o.rempel@pengutronix.de/ > > Should I resend it to net? It depends ;) is the fix functionally depending on the above patch? If yes, please update the commit message including such info (and the fix will go via net-next). If instead this patch is correct even regarless of 89183b6ea8dd39771d92e99723f6cf60b5670dad, I *think* it should go via - net. Thanks! Paolo
diff --git a/drivers/net/phy/ax88796b.c b/drivers/net/phy/ax88796b.c index 457896337505..0f1e617a26c9 100644 --- a/drivers/net/phy/ax88796b.c +++ b/drivers/net/phy/ax88796b.c @@ -88,8 +88,10 @@ static void asix_ax88772a_link_change_notify(struct phy_device *phydev) /* Reset PHY, otherwise MII_LPA will provide outdated information. * This issue is reproducible only with some link partner PHYs */ - if (phydev->state == PHY_NOLINK && phydev->drv->soft_reset) - phydev->drv->soft_reset(phydev); + if (phydev->state == PHY_NOLINK) { + phy_init_hw(phydev); + phy_start_aneg(phydev); + } } static struct phy_driver asix_driver[] = {
In case of asix_ax88772a_link_change_notify() workaround, we run soft reset which will automatically clear MII_ADVERTISE configuration. The PHYlib framework do not know about changed configuration state of the PHY, so we need use phy_init_hw() to reinit PHY configuration. Fixes: dde258469257 ("net: usb/phy: asix: add support for ax88772A/C PHYs") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/ax88796b.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)