diff mbox series

[v2] net: tipc: fix possible refcount leak in tipc_sk_create()

Message ID 20220629063418.21620-1-hbh25y@gmail.com (mailing list archive)
State Accepted
Commit 00aff3590fc0a73bddd3b743863c14e76fd35c0c
Delegated to: Netdev Maintainers
Headers show
Series [v2] net: tipc: fix possible refcount leak in tipc_sk_create() | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Hangyu Hua June 29, 2022, 6:34 a.m. UTC
Free sk in case tipc_sk_insert() fails.

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---

v2: use a succinct commit log.

 net/tipc/socket.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tung Quang Nguyen June 29, 2022, 9:52 a.m. UTC | #1
> Subject: [PATCH v2] net: tipc: fix possible refcount leak in tipc_sk_create()
> 
> Free sk in case tipc_sk_insert() fails.
> 
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> 
> v2: use a succinct commit log.
> 
>  net/tipc/socket.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 17f8c523e33b..43509c7e90fc 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
>  	sock_init_data(sock, sk);
>  	tipc_set_sk_state(sk, TIPC_OPEN);
>  	if (tipc_sk_insert(tsk)) {
> +		sk_free(sk);
>  		pr_warn("Socket create failed; port number exhausted\n");
>  		return -EINVAL;
>  	}
> --
> 2.25.1
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
patchwork-bot+netdevbpf@kernel.org June 29, 2022, 1 p.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 29 Jun 2022 14:34:18 +0800 you wrote:
> Free sk in case tipc_sk_insert() fails.
> 
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
> 
> v2: use a succinct commit log.
> 
> [...]

Here is the summary with links:
  - [v2] net: tipc: fix possible refcount leak in tipc_sk_create()
    https://git.kernel.org/netdev/net/c/00aff3590fc0

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 17f8c523e33b..43509c7e90fc 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -502,6 +502,7 @@  static int tipc_sk_create(struct net *net, struct socket *sock,
 	sock_init_data(sock, sk);
 	tipc_set_sk_state(sk, TIPC_OPEN);
 	if (tipc_sk_insert(tsk)) {
+		sk_free(sk);
 		pr_warn("Socket create failed; port number exhausted\n");
 		return -EINVAL;
 	}