| Message ID | 20220629154832.56986-5-laoar.shao@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf: Minor fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for bpf-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 11 of 11 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
| bpf/vmtest-bpf-next-PR | fail | PR summary |
| bpf/vmtest-bpf-next-VM_Test-2 | fail | Logs for Kernel LATEST on ubuntu-latest with llvm-15 |
| bpf/vmtest-bpf-next-VM_Test-1 | fail | Logs for Kernel LATEST on ubuntu-latest with gcc |
| bpf/vmtest-bpf-next-VM_Test-3 | fail | Logs for Kernel LATEST on z15 with gcc |
On 29/06/2022 16:48, Yafang Shao wrote: > For example, > /sys/fs/bpf/maps.debug is a bpf link, when you run `bpftool map show` to > show it, > - before > $ bpftool map show pinned /sys/fs/bpf/maps.debug > Error: incorrect object type: unknown > - after > $ bpftool map show pinned /sys/fs/bpf/maps.debug > Error: incorrect object type: link > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > --- > tools/bpf/bpftool/common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c > index a0d4acd7c54a..5e979269c89a 100644 > --- a/tools/bpf/bpftool/common.c > +++ b/tools/bpf/bpftool/common.c > @@ -251,6 +251,7 @@ const char *get_fd_type_name(enum bpf_obj_type type) > [BPF_OBJ_UNKNOWN] = "unknown", > [BPF_OBJ_PROG] = "prog", > [BPF_OBJ_MAP] = "map", > + [BPF_OBJ_LINK] = "link", > }; > > if (type < 0 || type >= ARRAY_SIZE(names) || !names[type]) Reviewed-by: Quentin Monnet <quentin@isovalent.com> Thanks!
On 6/29/22 6:22 PM, Quentin Monnet wrote: > On 29/06/2022 16:48, Yafang Shao wrote: >> For example, >> /sys/fs/bpf/maps.debug is a bpf link, when you run `bpftool map show` to >> show it, >> - before >> $ bpftool map show pinned /sys/fs/bpf/maps.debug >> Error: incorrect object type: unknown >> - after >> $ bpftool map show pinned /sys/fs/bpf/maps.debug >> Error: incorrect object type: link >> >> Signed-off-by: Yafang Shao <laoar.shao@gmail.com> >> --- >> tools/bpf/bpftool/common.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c >> index a0d4acd7c54a..5e979269c89a 100644 >> --- a/tools/bpf/bpftool/common.c >> +++ b/tools/bpf/bpftool/common.c >> @@ -251,6 +251,7 @@ const char *get_fd_type_name(enum bpf_obj_type type) >> [BPF_OBJ_UNKNOWN] = "unknown", >> [BPF_OBJ_PROG] = "prog", >> [BPF_OBJ_MAP] = "map", >> + [BPF_OBJ_LINK] = "link", >> }; >> >> if (type < 0 || type >= ARRAY_SIZE(names) || !names[type]) > > Reviewed-by: Quentin Monnet <quentin@isovalent.com> (Took this one in so far given fairly independent of the rest, thanks Yafang!)
diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index a0d4acd7c54a..5e979269c89a 100644 --- a/tools/bpf/bpftool/common.c +++ b/tools/bpf/bpftool/common.c @@ -251,6 +251,7 @@ const char *get_fd_type_name(enum bpf_obj_type type) [BPF_OBJ_UNKNOWN] = "unknown", [BPF_OBJ_PROG] = "prog", [BPF_OBJ_MAP] = "map", + [BPF_OBJ_LINK] = "link", }; if (type < 0 || type >= ARRAY_SIZE(names) || !names[type])
For example, /sys/fs/bpf/maps.debug is a bpf link, when you run `bpftool map show` to show it, - before $ bpftool map show pinned /sys/fs/bpf/maps.debug Error: incorrect object type: unknown - after $ bpftool map show pinned /sys/fs/bpf/maps.debug Error: incorrect object type: link Signed-off-by: Yafang Shao <laoar.shao@gmail.com> --- tools/bpf/bpftool/common.c | 1 + 1 file changed, 1 insertion(+)