diff mbox series

[bpf-next] bpftool: remove attach_type_name forward declaration

Message ID 20220630093638.25916-1-tklauser@distanz.ch (mailing list archive)
State Accepted
Commit b0cbd6154a9a3964490cafa0a9444be626271bd9
Delegated to: BPF
Headers show
Series [bpf-next] bpftool: remove attach_type_name forward declaration | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-VM_Test-3 fail Logs for Kernel LATEST on z15 with gcc
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 9 maintainers not CCed: netdev@vger.kernel.org daniel@iogearbox.net songliubraving@fb.com ast@kernel.org yhs@fb.com john.fastabend@gmail.com kafai@fb.com andrii@kernel.org kpsingh@kernel.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-PR fail PR summary
bpf/vmtest-bpf-next-VM_Test-1 success Logs for Kernel LATEST on ubuntu-latest with gcc
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Kernel LATEST on ubuntu-latest with llvm-15

Commit Message

Tobias Klauser June 30, 2022, 9:36 a.m. UTC
The attach_type_name definition was removed in commit 1ba5ad36e00f
("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
declaration in main.h as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 tools/bpf/bpftool/main.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Quentin Monnet June 30, 2022, 10:07 a.m. UTC | #1
On 30/06/2022 10:36, Tobias Klauser wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  tools/bpf/bpftool/main.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
> index 589cb76b227a..5e5060c2ac04 100644
> --- a/tools/bpf/bpftool/main.h
> +++ b/tools/bpf/bpftool/main.h
> @@ -63,8 +63,6 @@ static inline void *u64_to_ptr(__u64 ptr)
>  #define HELP_SPEC_LINK							\
>  	"LINK := { id LINK_ID | pinned FILE }"
>  
> -extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
> -
>  /* keep in sync with the definition in skeleton/pid_iter.bpf.c */
>  enum bpf_obj_type {
>  	BPF_OBJ_UNKNOWN,

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thanks!
patchwork-bot+netdevbpf@kernel.org June 30, 2022, 2:20 p.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Thu, 30 Jun 2022 11:36:38 +0200 you wrote:
> The attach_type_name definition was removed in commit 1ba5ad36e00f
> ("bpftool: Use libbpf_bpf_attach_type_str"). Remove its forward
> declaration in main.h as well.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  tools/bpf/bpftool/main.h | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [bpf-next] bpftool: remove attach_type_name forward declaration
    https://git.kernel.org/bpf/bpf-next/c/b0cbd6154a9a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/bpf/bpftool/main.h b/tools/bpf/bpftool/main.h
index 589cb76b227a..5e5060c2ac04 100644
--- a/tools/bpf/bpftool/main.h
+++ b/tools/bpf/bpftool/main.h
@@ -63,8 +63,6 @@  static inline void *u64_to_ptr(__u64 ptr)
 #define HELP_SPEC_LINK							\
 	"LINK := { id LINK_ID | pinned FILE }"
 
-extern const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE];
-
 /* keep in sync with the definition in skeleton/pid_iter.bpf.c */
 enum bpf_obj_type {
 	BPF_OBJ_UNKNOWN,