| Message ID | 20220630140237.692986-5-michael@walle.cc (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: lan966x: hardcode port count | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 3 of 3 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 30/06/2022 16:02, Michael Walle wrote: > The old generic microchip,lan966x-switch compatible string was > deprecated. Use the new one. > > Signed-off-by: Michael Walle <michael@walle.cc> > --- > arch/arm/boot/dts/lan966x.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi > index 48971d80c82c..da0657c57cdf 100644 > --- a/arch/arm/boot/dts/lan966x.dtsi > +++ b/arch/arm/boot/dts/lan966x.dtsi > @@ -85,7 +85,7 @@ soc { > ranges; > > switch: switch@e0000000 { > - compatible = "microchip,lan966x-switch"; > + compatible = "microchip,lan9668-switch"; While technically correct, the change cannot go via independent trees and may break out-of-tree users of this DTS. Usually the nicer way is to use two compatibles (the old as fallback). Anyway, this one is fine with me - up to subarch maintainer. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi index 48971d80c82c..da0657c57cdf 100644 --- a/arch/arm/boot/dts/lan966x.dtsi +++ b/arch/arm/boot/dts/lan966x.dtsi @@ -85,7 +85,7 @@ soc { ranges; switch: switch@e0000000 { - compatible = "microchip,lan966x-switch"; + compatible = "microchip,lan9668-switch"; reg = <0xe0000000 0x0100000>, <0xe2000000 0x0800000>; reg-names = "cpu", "gcb";
The old generic microchip,lan966x-switch compatible string was deprecated. Use the new one. Signed-off-by: Michael Walle <michael@walle.cc> --- arch/arm/boot/dts/lan966x.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)