| Message ID | 20220706235648.594609-1-justinstitt@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: rxrpc: fix clang -Wformat warning | expand |
Hi Justin, On Wed, Jul 06, 2022 at 04:56:48PM -0700, Justin Stitt wrote: > When building with Clang we encounter this warning: > | net/rxrpc/rxkad.c:434:33: error: format specifies type 'unsigned short' > | but the argument has type 'u32' (aka 'unsigned int') [-Werror,-Wformat] > | _leave(" = %d [set %hx]", ret, y); > > y is a u32 but the format specifier is `%hx`. Going from unsigned int to > short int results in a loss of data. This is surely not intended > behavior. If it is intended, the warning should be suppressed through > other means. > > This patch should get us closer to the goal of enabling the -Wformat > flag for Clang builds. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Justin Stitt <justinstitt@google.com> > --- > net/rxrpc/rxkad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c > index 08aab5c01437..aa180464ec37 100644 > --- a/net/rxrpc/rxkad.c > +++ b/net/rxrpc/rxkad.c > @@ -431,7 +431,7 @@ static int rxkad_secure_packet(struct rxrpc_call *call, > break; > } > > - _leave(" = %d [set %hx]", ret, y); > + _leave(" = %d [set %u]", ret, y); Should this just become %x to keep printing it as a hexidecimal number? Cheers, Nathan > return ret; > } > > -- > 2.37.0.rc0.161.g10f37bed90-goog >
On Wed, 2022-07-06 at 16:56 -0700, Justin Stitt wrote: > When building with Clang we encounter this warning: > > net/rxrpc/rxkad.c:434:33: error: format specifies type 'unsigned short' > > but the argument has type 'u32' (aka 'unsigned int') [-Werror,-Wformat] > > _leave(" = %d [set %hx]", ret, y); Does anyone still use these debugging macros in rxrpc or is it historic cruft? net/rxrpc/ar-internal.h-#define kenter(FMT,...) dbgprintk("==> %s("FMT")",__func__ ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kleave(FMT,...) dbgprintk("<== %s()"FMT"",__func__ ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kdebug(FMT,...) dbgprintk(" "FMT ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kproto(FMT,...) dbgprintk("### "FMT ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define knet(FMT,...) dbgprintk("@@@ "FMT ,##__VA_ARGS__) etc... [] net/rxrpc/Kconfig:config AF_RXRPC_DEBUG net/rxrpc/Kconfig- bool "RxRPC dynamic debugging" net/rxrpc/Kconfig- help net/rxrpc/Kconfig- Say Y here to make runtime controllable debugging messages appear. net/rxrpc/Kconfig- net/rxrpc/Kconfig- See Documentation/networking/rxrpc.rst This seems to show there is debugging documentation, but it doesn't seem to exist in this file. > diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c [] > @@ -431,7 +431,7 @@ static int rxkad_secure_packet(struct rxrpc_call *call, > break; > } > > - _leave(" = %d [set %hx]", ret, y); > + _leave(" = %d [set %u]", ret, y); > return ret; > } >
Joe Perches <joe@perches.com> wrote:
> Does anyone still use these debugging macros in rxrpc
Yes.
David
Joe Perches <joe@perches.com> wrote: > net/rxrpc/Kconfig:config AF_RXRPC_DEBUG > net/rxrpc/Kconfig- bool "RxRPC dynamic debugging" > net/rxrpc/Kconfig- help > net/rxrpc/Kconfig- Say Y here to make runtime controllable debugging messages appear. > net/rxrpc/Kconfig- > net/rxrpc/Kconfig- See Documentation/networking/rxrpc.rst > > This seems to show there is debugging documentation, but it > doesn't seem to exist in this file. Try looking in net/rxrpc/ar-internal.h: #elif defined(CONFIG_AF_RXRPC_DEBUG) David
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 08aab5c01437..aa180464ec37 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -431,7 +431,7 @@ static int rxkad_secure_packet(struct rxrpc_call *call, break; } - _leave(" = %d [set %hx]", ret, y); + _leave(" = %d [set %u]", ret, y); return ret; }
When building with Clang we encounter this warning: | net/rxrpc/rxkad.c:434:33: error: format specifies type 'unsigned short' | but the argument has type 'u32' (aka 'unsigned int') [-Werror,-Wformat] | _leave(" = %d [set %hx]", ret, y); y is a u32 but the format specifier is `%hx`. Going from unsigned int to short int results in a loss of data. This is surely not intended behavior. If it is intended, the warning should be suppressed through other means. This patch should get us closer to the goal of enabling the -Wformat flag for Clang builds. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Justin Stitt <justinstitt@google.com> --- net/rxrpc/rxkad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)