diff mbox series

[16/16] lib: create CONFIG_DEBUG_BITMAP parameter

Message ID 20220718192844.1805158-17-yury.norov@gmail.com (mailing list archive)
State Not Applicable
Delegated to: Netdev Maintainers
Headers show
Series Introduce DEBUG_BITMAP config option and bitmap_check_params() | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Yury Norov July 18, 2022, 7:28 p.m. UTC
Create CONFIG_DEBUG_BITMAP parameter to let people use
new option. Default is N.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/Kconfig.debug | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andy Shevchenko July 18, 2022, 9:39 p.m. UTC | #1
On Mon, Jul 18, 2022 at 12:28:44PM -0700, Yury Norov wrote:
> Create CONFIG_DEBUG_BITMAP parameter to let people use
> new option. Default is N.

Even if a separate, it should follow immediately the implementation.
Yury Norov July 20, 2022, 4:49 p.m. UTC | #2
On Tue, Jul 19, 2022 at 12:39:02AM +0300, Andy Shevchenko wrote:
> On Mon, Jul 18, 2022 at 12:28:44PM -0700, Yury Norov wrote:
> > Create CONFIG_DEBUG_BITMAP parameter to let people use
> > new option. Default is N.
> 
> Even if a separate, it should follow immediately the implementation.

If it follows the 1st patch immediately, and becomes enabled, it will
generate a lot of noise for those who bisect and occasionally jumps
into a mid of the series.

There are quite a lot of patchsets that create a feature in many
patches, and explicitly enable it in the very last patch.
diff mbox series

Patch

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 2e24db4bff19..cde1b5b7bb9d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -533,6 +533,13 @@  config DEBUG_FORCE_WEAK_PER_CPU
 
 endmenu # "Compiler options"
 
+config DEBUG_BITMAP
+	bool "Debug bitmaps"
+	help
+	  Say Y here if you want to check bitmap functions parameters at
+	  the runtime. Enable CONFIG_DEBUG_BITMAP only for debugging because
+	  it may affect performance.
+
 menu "Generic Kernel Debugging Instruments"
 
 config MAGIC_SYSRQ