diff mbox series

[net] ptp: ocp: Select CRC16 in the Kconfig.

Message ID 20220726220604.1339972-1-jonathan.lemon@gmail.com (mailing list archive)
State Accepted
Commit 0c104556267242d922a3def60be8092b280e4fee
Delegated to: Netdev Maintainers
Headers show
Series [net] ptp: ocp: Select CRC16 in the Kconfig. | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jonathan Lemon July 26, 2022, 10:06 p.m. UTC
The crc16() function is used to check the firmware validity, but
the library was not explicitly selected.

Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
CC: Richard Cochran <richardcochran@gmail.com>
CC: Vadim Fedorenko <vadfed@fb.com>
---
 drivers/ptp/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Vadim Fedorenko July 28, 2022, 12:04 a.m. UTC | #1
On 26.07.2022 23:06, Jonathan Lemon wrote:
> The crc16() function is used to check the firmware validity, but
> the library was not explicitly selected.
> 
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> CC: Richard Cochran <richardcochran@gmail.com>
> CC: Vadim Fedorenko <vadfed@fb.com>
> ---
>   drivers/ptp/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
Acked-by: Vadim Fedorenko <vadfed@fb.com>
patchwork-bot+netdevbpf@kernel.org July 28, 2022, 1:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 26 Jul 2022 15:06:04 -0700 you wrote:
> The crc16() function is used to check the firmware validity, but
> the library was not explicitly selected.
> 
> Fixes: 3c3673bde50c ("ptp: ocp: Add firmware header checks")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] ptp: ocp: Select CRC16 in the Kconfig.
    https://git.kernel.org/netdev/net/c/0c1045562672

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 458218f88c5e..fe4971b65c64 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -176,6 +176,7 @@  config PTP_1588_CLOCK_OCP
 	depends on !S390
 	depends on COMMON_CLK
 	select NET_DEVLINK
+	select CRC16
 	help
 	  This driver adds support for an OpenCompute time card.