| Message ID | 20220727055912.568391-1-jiri@resnulli.us (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2bb88b2c4f7334bd91c734f3983492a133250edb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 5 this patch: 5 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 2 this patch: 2 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 27 Jul 2022 07:59:12 +0200 you wrote: > From: Jiri Pirko <jiri@nvidia.com> > > The net_eq() check is already performed inside > devlinks_xa_for_each_registered_get() helper, so remove the redundant > appearance. > > Signed-off-by: Jiri Pirko <jiri@nvidia.com> > > [...] Here is the summary with links: - [net-next] net: devlink: remove redundant net_eq() check from sb_pool_get_dumpit() https://git.kernel.org/netdev/net-next/c/2bb88b2c4f73 You are awesome, thank you!
diff --git a/net/core/devlink.c b/net/core/devlink.c index 698b2d6e0ec7..ca4c9939d569 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -2642,8 +2642,7 @@ static int devlink_nl_cmd_sb_pool_get_dumpit(struct sk_buff *msg, mutex_lock(&devlink_mutex); devlinks_xa_for_each_registered_get(sock_net(msg->sk), index, devlink) { - if (!net_eq(devlink_net(devlink), sock_net(msg->sk)) || - !devlink->ops->sb_pool_get) + if (!devlink->ops->sb_pool_get) goto retry; devl_lock(devlink);