| Message ID | 20220728161259.1088662-2-mkp@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] openvswitch: Fix double reporting of drops in dropwatch | expand |
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 029f9c3e1c28..3eee4b0a2005 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -561,8 +561,9 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb, out: if (err) skb_tx_error(skb); - kfree_skb(user_skb); - kfree_skb(nskb); + consume_skb(user_skb); + consume_skb(nskb); + return err; }
Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This patch will consume the skbs instead. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2109957 Signed-off-by: Mike Pattrick <mkp@redhat.com> --- net/openvswitch/datapath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)