[RFC,bpf-next,14/17] selftests/bpf: Add fentry tracing multi func test

Message ID	20220808140626.422731-15-jolsa@kernel.org (mailing list archive)
State	RFC
Delegated to:	BPF
Headers	show Return-Path: <bpf-owner@kernel.org> From: Jiri Olsa <jolsa@kernel.org> To: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org> Cc: bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@chromium.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com> Subject: [RFC PATCH bpf-next 14/17] selftests/bpf: Add fentry tracing multi func test Date: Mon, 8 Aug 2022 16:06:23 +0200 Message-Id: <20220808140626.422731-15-jolsa@kernel.org> In-Reply-To: <20220808140626.422731-1-jolsa@kernel.org> References: <20220808140626.422731-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	bpf: Add tracing multi link \| expand [RFC,bpf-next,00/17] bpf: Add tracing multi link [RFC,bpf-next,01/17] bpf: Link shimlink directly in trampoline [RFC,bpf-next,02/17] bpf: Replace bpf_tramp_links with bpf_tramp_progs [RFC,bpf-next,03/17] bpf: Store trampoline progs in arrays [RFC,bpf-next,04/17] bpf: Add multi tracing attach types [RFC,bpf-next,05/17] bpf: Add bpf_tramp_id object [RFC,bpf-next,06/17] bpf: Pass image struct to reg/unreg/modify fentry functions [RFC,bpf-next,07/17] bpf: Add support to postpone trampoline update [RFC,bpf-next,08/17] bpf: Factor bpf_trampoline_lookup function [RFC,bpf-next,09/17] bpf: Factor bpf_trampoline_put function [RFC,bpf-next,10/17] bpf: Add support to attach program to multiple trampolines [RFC,bpf-next,11/17] bpf: Add support to create tracing multi link [RFC,bpf-next,12/17] libbpf: Add btf__find_by_glob_kind function [RFC,bpf-next,13/17] libbpf: Add support to create tracing multi link [RFC,bpf-next,14/17] selftests/bpf: Add fentry tracing multi func test [RFC,bpf-next,15/17] selftests/bpf: Add fexit tracing multi func test [RFC,bpf-next,16/17] selftests/bpf: Add fentry/fexit tracing multi func test [RFC,bpf-next,17/17] selftests/bpf: Add mixed tracing multi func test

Context	Check	Description
netdev/tree_selection	success	Clearly marked for bpf-next, async
netdev/apply	fail	Patch does not apply to bpf-next
bpf/vmtest-bpf-next-PR	fail	merge-conflict

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 8d59ec7f4c2d..24f0ace18af2 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -348,7 +348,7 @@ SKEL_BLACKLIST := btf__% test_pinning_invalid.c test_sk_assign.c LINKED_SKELS := test_static_linked.skel.h linked_funcs.skel.h \ linked_vars.skel.h linked_maps.skel.h \ test_subskeleton.skel.h test_subskeleton_lib.skel.h \ - test_usdt.skel.h + test_usdt.skel.h tracing_multi_fentry_test.skel.h LSKELS := kfunc_call_test.c fentry_test.c fexit_test.c fexit_sleep.c \ test_ringbuf.c atomics.c trace_printk.c trace_vprintk.c \ @@ -366,6 +366,7 @@ linked_maps.skel.h-deps := linked_maps1.o linked_maps2.o test_subskeleton.skel.h-deps := test_subskeleton_lib2.o test_subskeleton_lib.o test_subskeleton.o test_subskeleton_lib.skel.h-deps := test_subskeleton_lib2.o test_subskeleton_lib.o test_usdt.skel.h-deps := test_usdt.o test_usdt_multispec.o +tracing_multi_fentry_test.skel.h-deps := tracing_multi_fentry.o tracing_multi_check.o LINKED_BPF_SRCS := $(patsubst %.o,%.c,$(foreach skel,$(LINKED_SKELS),$($(skel)-deps))) diff --git a/tools/testing/selftests/bpf/prog_tests/tracing_multi.c b/tools/testing/selftests/bpf/prog_tests/tracing_multi.c new file mode 100644 index 000000000000..fbf2108ebb8a --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/tracing_multi.c @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <test_progs.h> +#include "tracing_multi_fentry_test.skel.h" +#include "trace_helpers.h" + +static void multi_fentry_test(void) +{ + LIBBPF_OPTS(bpf_test_run_opts, topts); + struct tracing_multi_fentry_test *skel = NULL; + int err, prog_fd; + + skel = tracing_multi_fentry_test__open_and_load(); + if (!ASSERT_OK_PTR(skel, "fentry_multi_skel_load")) + goto cleanup; + + err = tracing_multi_fentry_test__attach(skel); + if (!ASSERT_OK(err, "fentry_attach")) + goto cleanup; + + prog_fd = bpf_program__fd(skel->progs.test); + err = bpf_prog_test_run_opts(prog_fd, &topts); + ASSERT_OK(err, "test_run"); + + ASSERT_EQ(skel->bss->test_result, 8, "test_result"); + +cleanup: + tracing_multi_fentry_test__destroy(skel); +} + +void test_tracing_multi_test(void) +{ + if (test__start_subtest("fentry")) + multi_fentry_test(); +} diff --git a/tools/testing/selftests/bpf/progs/tracing_multi_check.c b/tools/testing/selftests/bpf/progs/tracing_multi_check.c new file mode 100644 index 000000000000..945dc4d070e1 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/tracing_multi_check.c @@ -0,0 +1,132 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <linux/bpf.h> +#include <bpf/bpf_helpers.h> +#include <bpf/bpf_tracing.h> + +extern const void bpf_fentry_test1 __ksym; +extern const void bpf_fentry_test2 __ksym; +extern const void bpf_fentry_test3 __ksym; +extern const void bpf_fentry_test4 __ksym; +extern const void bpf_fentry_test5 __ksym; +extern const void bpf_fentry_test6 __ksym; +extern const void bpf_fentry_test7 __ksym; +extern const void bpf_fentry_test8 __ksym; + +void multi_arg_check(__u64 *ctx, __u64 *test_result) +{ + void *ip = (void *) bpf_get_func_ip(ctx); + __u64 value = 0; + + if (ip == &bpf_fentry_test1) { + int a; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = (int) value; + + *test_result += a == 1; + } else if (ip == &bpf_fentry_test2) { + __u64 b; + int a; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = (int) value; + if (bpf_get_func_arg(ctx, 1, &value)) + return; + b = value; + + *test_result += a == 2 && b == 3; + } else if (ip == &bpf_fentry_test3) { + char a, b; + __u64 c; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = (int) value; + if (bpf_get_func_arg(ctx, 1, &value)) + return; + b = (int) value; + if (bpf_get_func_arg(ctx, 2, &value)) + return; + c = value; + + *test_result += a == 4 && b == 5 && c == 6; + } else if (ip == &bpf_fentry_test4) { + void *a; + char b; + int c; + __u64 d; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = (void *) value; + if (bpf_get_func_arg(ctx, 1, &value)) + return; + b = (char) value; + if (bpf_get_func_arg(ctx, 2, &value)) + return; + c = (int) value; + if (bpf_get_func_arg(ctx, 3, &value)) + return; + d = value; + + *test_result += a == (void *) 7 && b == 8 && c == 9 && d == 10; + } else if (ip == &bpf_fentry_test5) { + __u64 a; + void *b; + short c; + int d; + __u64 e; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = value; + if (bpf_get_func_arg(ctx, 1, &value)) + return; + b = (void *) value; + if (bpf_get_func_arg(ctx, 2, &value)) + return; + c = (short) value; + if (bpf_get_func_arg(ctx, 3, &value)) + return; + d = (int) value; + if (bpf_get_func_arg(ctx, 4, &value)) + return; + e = value; + + *test_result += a == 11 && b == (void *) 12 && c == 13 && d == 14 && e == 15; + } else if (ip == &bpf_fentry_test6) { + __u64 a; + void *b; + short c; + int d; + void *e; + __u64 f; + + if (bpf_get_func_arg(ctx, 0, &value)) + return; + a = value; + if (bpf_get_func_arg(ctx, 1, &value)) + return; + b = (void *) value; + if (bpf_get_func_arg(ctx, 2, &value)) + return; + c = (short) value; + if (bpf_get_func_arg(ctx, 3, &value)) + return; + d = (int) value; + if (bpf_get_func_arg(ctx, 4, &value)) + return; + e = (void *) value; + if (bpf_get_func_arg(ctx, 5, &value)) + return; + f = value; + + *test_result += a == 16 && b == (void *) 17 && c == 18 && d == 19 && e == (void *) 20 && f == 21; + } else if (ip == &bpf_fentry_test7) { + *test_result += 1; + } else if (ip == &bpf_fentry_test8) { + *test_result += 1; + } +} diff --git a/tools/testing/selftests/bpf/progs/tracing_multi_fentry.c b/tools/testing/selftests/bpf/progs/tracing_multi_fentry.c new file mode 100644 index 000000000000..b78d36772aa6 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/tracing_multi_fentry.c @@ -0,0 +1,17 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <linux/bpf.h> +#include <bpf/bpf_helpers.h> +#include <bpf/bpf_tracing.h> + +char _license[] SEC("license") = "GPL"; + +__u64 test_result = 0; + +__hidden extern void multi_arg_check(__u64 *ctx, __u64 *test_result); + +SEC("fentry.multi/bpf_fentry_test*") +int BPF_PROG(test, __u64 a, __u64 b, __u64 c, __u64 d, __u64 e, __u64 f) +{ + multi_arg_check(ctx, &test_result); + return 0; +}

[RFC,bpf-next,14/17] selftests/bpf: Add fentry tracing multi func test

Checks

Commit Message

Patch