[bpf,v2,5/9] bpf: Check the validity of max_rdwr_access for sock local storage map iterator

Commit Message

Hou Tao Aug. 10, 2022, 8:05 a.m. UTC

From: Hou Tao <[e-mail]>

The value of sock local storage map is writable in map iterator, so check
max_rdwr_access instead of max_rdonly_access.

Fixes: 5ce6e77c7edf ("bpf: Implement bpf iterator for sock local storage map")
Signed-off-by: Hou Tao <[e-mail]>
Acked-by: Yonghong Song <[e-mail]>
---
 net/core/bpf_sk_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin KaFai Lau Aug. 10, 2022, 4:59 p.m. UTC | #1

On Wed, Aug 10, 2022 at 04:05:34PM +0800, Hou Tao wrote:
> From: Hou Tao <[e-mail]>
> 
> The value of sock local storage map is writable in map iterator, so check
> max_rdwr_access instead of max_rdonly_access.
Acked-by: Martin KaFai Lau <[e-mail]>

Patch

diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c
index 83b89ba824d7..1b7f385643b4 100644
--- a/net/core/bpf_sk_storage.c
+++ b/net/core/bpf_sk_storage.c
@@ -904,7 +904,7 @@  static int bpf_iter_attach_map(struct bpf_prog *prog,
 	if (map->map_type != BPF_MAP_TYPE_SK_STORAGE)
 		goto put_map;
 
-	if (prog->aux->max_rdonly_access > map->value_size) {
+	if (prog->aux->max_rdwr_access > map->value_size) {
 		err = -EACCES;
 		goto put_map;
 	}