Message ID | 20220815061023.51318-1-shaozhengchao@huawei.com (mailing list archive) |
---|---|
State | Accepted |
Commit | cfc111d5391dda87310e7a385a9e17f300a8a97c |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next] net: sched: delete unused input parameter in qdisc_create | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 15 Aug 2022 14:10:23 +0800 you wrote: > The input parameter p is unused in qdisc_create. Delete it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > net/sched/sch_api.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Here is the summary with links: - [net-next] net: sched: delete unused input parameter in qdisc_create https://git.kernel.org/netdev/net-next/c/cfc111d5391d You are awesome, thank you!
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index fe596bf3cb99..8abb85c51e45 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -1164,7 +1164,7 @@ static int qdisc_block_indexes_set(struct Qdisc *sch, struct nlattr **tca, static struct Qdisc *qdisc_create(struct net_device *dev, struct netdev_queue *dev_queue, - struct Qdisc *p, u32 parent, u32 handle, + u32 parent, u32 handle, struct nlattr **tca, int *errp, struct netlink_ext_ack *extack) { @@ -1634,7 +1634,7 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n, } if (clid == TC_H_INGRESS) { if (dev_ingress_queue(dev)) { - q = qdisc_create(dev, dev_ingress_queue(dev), p, + q = qdisc_create(dev, dev_ingress_queue(dev), tcm->tcm_parent, tcm->tcm_parent, tca, &err, extack); } else { @@ -1651,7 +1651,7 @@ static int tc_modify_qdisc(struct sk_buff *skb, struct nlmsghdr *n, else dev_queue = netdev_get_tx_queue(dev, 0); - q = qdisc_create(dev, dev_queue, p, + q = qdisc_create(dev, dev_queue, tcm->tcm_parent, tcm->tcm_handle, tca, &err, extack); }
The input parameter p is unused in qdisc_create. Delete it. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- net/sched/sch_api.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)