Message ID | 20220816055231.717006-1-asavkov@redhat.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 807662cac66af0dfca60ce1cf784063da6ec2f65 |
Delegated to: | BPF |
Headers | show |
Series | [bpf-next,v2] selftests/bpf: fix attach point for non-x86 arches in test_progs/lsm | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Tue, 16 Aug 2022 07:52:31 +0200 you wrote: > Use SYS_PREFIX macro from bpf_misc.h instead of hard-coded '__x64_' > prefix for sys_setdomainname attach point in lsm test. > > Signed-off-by: Artem Savkov <asavkov@redhat.com> > --- > tools/testing/selftests/bpf/DENYLIST.s390x | 2 +- > tools/testing/selftests/bpf/progs/lsm.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) Here is the summary with links: - [bpf-next,v2] selftests/bpf: fix attach point for non-x86 arches in test_progs/lsm https://git.kernel.org/bpf/bpf-next/c/807662cac66a You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x index e33cab34d22f..9d8de15e725e 100644 --- a/tools/testing/selftests/bpf/DENYLIST.s390x +++ b/tools/testing/selftests/bpf/DENYLIST.s390x @@ -43,7 +43,7 @@ test_bpffs # bpffs test failed 255 test_bprm_opts # failed to auto-attach program 'secure_exec': -524 (trampoline) test_ima # failed to auto-attach program 'ima': -524 (trampoline) test_local_storage # failed to auto-attach program 'unlink_hook': -524 (trampoline) -test_lsm # failed to find kernel BTF type ID of '__x64_sys_setdomainname': -3 (?) +test_lsm # attach unexpected error: -524 (trampoline) test_overhead # attach_fentry unexpected error: -524 (trampoline) test_profiler # unknown func bpf_probe_read_str#45 (overlapping) timer # failed to auto-attach program 'test1': -524 (trampoline) diff --git a/tools/testing/selftests/bpf/progs/lsm.c b/tools/testing/selftests/bpf/progs/lsm.c index 33694ef8acfa..d8d8af623bc2 100644 --- a/tools/testing/selftests/bpf/progs/lsm.c +++ b/tools/testing/selftests/bpf/progs/lsm.c @@ -4,6 +4,7 @@ * Copyright 2020 Google LLC. */ +#include "bpf_misc.h" #include "vmlinux.h" #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> @@ -160,7 +161,7 @@ int BPF_PROG(test_task_free, struct task_struct *task) int copy_test = 0; -SEC("fentry.s/__x64_sys_setdomainname") +SEC("fentry.s/" SYS_PREFIX "sys_setdomainname") int BPF_PROG(test_sys_setdomainname, struct pt_regs *regs) { void *ptr = (void *)PT_REGS_PARM1(regs);
Use SYS_PREFIX macro from bpf_misc.h instead of hard-coded '__x64_' prefix for sys_setdomainname attach point in lsm test. Signed-off-by: Artem Savkov <asavkov@redhat.com> --- tools/testing/selftests/bpf/DENYLIST.s390x | 2 +- tools/testing/selftests/bpf/progs/lsm.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)